Code review comment for lp:~aacid/unity-2d/fixspreadtogglingfromlauncher

Revision history for this message
Gerry Boland (gerboland) wrote :

Being pedantic, you could use "pgrep" instead of
bash -c "ps -A | grep unity-2d-spread"

Please also add the bug URL to the References section. Helps explain why we have such a test, in case manual tests are done too.

Also any reason why you don't use "spreadItem.tap" instead of "spreadItem.move_mouse; XDo::Mouse.click"

review: Needs Fixing

« Back to merge proposal