Merge lp:~aacid/unity-2d/emit_signals into lp:unity-2d

Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 1078
Merged at revision: 1093
Proposed branch: lp:~aacid/unity-2d/emit_signals
Merge into: lp:unity-2d
Diff against target: 36 lines (+4/-4)
2 files modified
panel/applets/appname/menubarwidget.cpp (+2/-2)
panel/applets/appname/windowhelper.cpp (+2/-2)
To merge this branch: bzr merge lp:~aacid/unity-2d/emit_signals
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+103132@code.launchpad.net

Commit message

Add some Q_EMIT they are not needed but help when reading the code

Description of the change

Add some Q_EMIT they are not needed but help when reading the code

To post a comment you must log in.
lp:~aacid/unity-2d/emit_signals updated
1078. By Albert Astals Cid

Merge lp:unity-2d

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'panel/applets/appname/menubarwidget.cpp'
--- panel/applets/appname/menubarwidget.cpp 2012-04-23 14:42:48 +0000
+++ panel/applets/appname/menubarwidget.cpp 2012-04-30 13:34:30 +0000
@@ -76,7 +76,7 @@
76{76{
77 if (m_isOpened != opened) {77 if (m_isOpened != opened) {
78 m_isOpened = opened;78 m_isOpened = opened;
79 isOpenedChanged();79 Q_EMIT isOpenedChanged();
80 }80 }
81}81}
8282
@@ -155,7 +155,7 @@
155 }155 }
156 if (m_isEmpty != empty) {156 if (m_isEmpty != empty) {
157 m_isEmpty = empty;157 m_isEmpty = empty;
158 isEmptyChanged();158 Q_EMIT isEmptyChanged();
159 }159 }
160}160}
161161
162162
=== modified file 'panel/applets/appname/windowhelper.cpp'
--- panel/applets/appname/windowhelper.cpp 2012-04-05 08:22:17 +0000
+++ panel/applets/appname/windowhelper.cpp 2012-04-30 13:34:30 +0000
@@ -132,8 +132,8 @@
132 d->m_connector.connect(G_OBJECT(d->m_window), "name-changed", G_CALLBACK(nameChangedCB), this);132 d->m_connector.connect(G_OBJECT(d->m_window), "name-changed", G_CALLBACK(nameChangedCB), this);
133 d->m_connector.connect(G_OBJECT(d->m_window), "state-changed", G_CALLBACK(stateChangedCB), this);133 d->m_connector.connect(G_OBJECT(d->m_window), "state-changed", G_CALLBACK(stateChangedCB), this);
134 }134 }
135 stateChanged();135 Q_EMIT stateChanged();
136 nameChanged();136 Q_EMIT nameChanged();
137}137}
138138
139bool WindowHelper::isMaximized() const139bool WindowHelper::isMaximized() const

Subscribers

People subscribed via source and target branches