Merge lp:~aacid/unity-2d/emit_signals into lp:unity-2d

Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 1078
Merged at revision: 1093
Proposed branch: lp:~aacid/unity-2d/emit_signals
Merge into: lp:unity-2d
Diff against target: 36 lines (+4/-4)
2 files modified
panel/applets/appname/menubarwidget.cpp (+2/-2)
panel/applets/appname/windowhelper.cpp (+2/-2)
To merge this branch: bzr merge lp:~aacid/unity-2d/emit_signals
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+103132@code.launchpad.net

Commit message

Add some Q_EMIT they are not needed but help when reading the code

Description of the change

Add some Q_EMIT they are not needed but help when reading the code

To post a comment you must log in.
lp:~aacid/unity-2d/emit_signals updated
1078. By Albert Astals Cid

Merge lp:unity-2d

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panel/applets/appname/menubarwidget.cpp'
2--- panel/applets/appname/menubarwidget.cpp 2012-04-23 14:42:48 +0000
3+++ panel/applets/appname/menubarwidget.cpp 2012-04-30 13:34:30 +0000
4@@ -76,7 +76,7 @@
5 {
6 if (m_isOpened != opened) {
7 m_isOpened = opened;
8- isOpenedChanged();
9+ Q_EMIT isOpenedChanged();
10 }
11 }
12
13@@ -155,7 +155,7 @@
14 }
15 if (m_isEmpty != empty) {
16 m_isEmpty = empty;
17- isEmptyChanged();
18+ Q_EMIT isEmptyChanged();
19 }
20 }
21
22
23=== modified file 'panel/applets/appname/windowhelper.cpp'
24--- panel/applets/appname/windowhelper.cpp 2012-04-05 08:22:17 +0000
25+++ panel/applets/appname/windowhelper.cpp 2012-04-30 13:34:30 +0000
26@@ -132,8 +132,8 @@
27 d->m_connector.connect(G_OBJECT(d->m_window), "name-changed", G_CALLBACK(nameChangedCB), this);
28 d->m_connector.connect(G_OBJECT(d->m_window), "state-changed", G_CALLBACK(stateChangedCB), this);
29 }
30- stateChanged();
31- nameChanged();
32+ Q_EMIT stateChanged();
33+ Q_EMIT nameChanged();
34 }
35
36 bool WindowHelper::isMaximized() const

Subscribers

People subscribed via source and target branches