Merge lp:~aacid/ubuntu-ui-toolkit/env_var_disable_performance_monitor_warning_count into lp:~aacid/ubuntu-ui-toolkit/performance_monitor_env_vars

Proposed by Albert Astals Cid
Status: Superseded
Proposed branch: lp:~aacid/ubuntu-ui-toolkit/env_var_disable_performance_monitor_warning_count
Merge into: lp:~aacid/ubuntu-ui-toolkit/performance_monitor_env_vars
Diff against target: 21 lines (+2/-2)
1 file modified
src/Ubuntu/Components/plugin/ucperformancemonitor.cpp (+2/-2)
To merge this branch: bzr merge lp:~aacid/ubuntu-ui-toolkit/env_var_disable_performance_monitor_warning_count
Reviewer Review Type Date Requested Status
Albert Astals Cid Pending
Review via email: mp+296996@code.launchpad.net

This proposal has been superseded by a proposal from 2016-06-10.

Commit message

Using -1 as PERFORMANCE_MONITOR_WARNING_COUNT_THRESHOLD envvar disables the warning count threshold

To post a comment you must log in.

Unmerged revisions

1999. By Albert Astals Cid

Add envvars for performance monitor variables

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/plugin/ucperformancemonitor.cpp'
--- src/Ubuntu/Components/plugin/ucperformancemonitor.cpp 2016-06-09 18:25:04 +0000
+++ src/Ubuntu/Components/plugin/ucperformancemonitor.cpp 2016-06-09 19:55:27 +0000
@@ -71,7 +71,7 @@
7171
72void UCPerformanceMonitor::onApplicationStateChanged(Qt::ApplicationState state)72void UCPerformanceMonitor::onApplicationStateChanged(Qt::ApplicationState state)
73{73{
74 if (m_warningCount >= warningCountThreshold) {74 if (m_warningCount >= warningCountThreshold && warningCountThreshold != -1) {
75 // do not monitor performance if the warning count threshold was reached75 // do not monitor performance if the warning count threshold was reached
76 return;76 return;
77 }77 }
@@ -142,7 +142,7 @@
142 m_framesAboveThreshold = 0;142 m_framesAboveThreshold = 0;
143 }143 }
144144
145 if (m_warningCount >= warningCountThreshold) {145 if (m_warningCount >= warningCountThreshold && warningCountThreshold != -1) {
146 qCWarning(ucPerformance, "Too many warnings were given. Performance monitoring stops.");146 qCWarning(ucPerformance, "Too many warnings were given. Performance monitoring stops.");
147 connectToWindow(NULL);147 connectToWindow(NULL);
148 }148 }

Subscribers

People subscribed via source and target branches

to all changes: