Merge lp:~aacid/qtubuntu/fix_unregistered_metatype_warning into lp:qtubuntu

Proposed by Albert Astals Cid
Status: Merged
Approved by: Nick Dedekind
Approved revision: 372
Merged at revision: 374
Proposed branch: lp:~aacid/qtubuntu/fix_unregistered_metatype_warning
Merge into: lp:qtubuntu
Prerequisite: lp:~ci-train-bot/qtubuntu/qtubuntu-ubuntu-zesty-2415.1
Diff against target: 25 lines (+8/-0)
1 file modified
src/ubuntumirclient/qmirclientwindow.cpp (+8/-0)
To merge this branch: bzr merge lp:~aacid/qtubuntu/fix_unregistered_metatype_warning
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
Unity8 CI Bot continuous-integration Approve
Review via email: mp+317633@code.launchpad.net

Commit message

Register metatype used in queued invokeMethod

Otherwise I get
   QMetaMethod::invoke: Unable to handle unregistered datatype 'QPlatformWindow*'
when launching kate

Description of the change

Register metatype used in queued invokeMethod

Otherwise we get
    QMetaMethod::invoke: Unable to handle unregistered datatype 'QPlatformWindow*'

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:372
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/184/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4133
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4161
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4001
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4001/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4001
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4001/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4001
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4001/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4001
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4001/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4001
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4001/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4001
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4001/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/184/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Looks fine. Strange that it worked without.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/ubuntumirclient/qmirclientwindow.cpp'
--- src/ubuntumirclient/qmirclientwindow.cpp 2017-02-17 14:36:00 +0000
+++ src/ubuntumirclient/qmirclientwindow.cpp 2017-02-17 14:36:00 +0000
@@ -719,6 +719,8 @@
719 return mPersistentIdStr;719 return mPersistentIdStr;
720}720}
721721
722Q_DECLARE_METATYPE(QPlatformWindow*)
723
722QMirClientWindow::QMirClientWindow(QWindow *w, QMirClientInput *input, QMirClientNativeInterface *native,724QMirClientWindow::QMirClientWindow(QWindow *w, QMirClientInput *input, QMirClientNativeInterface *native,
723 QMirClientAppStateController *appState, EGLDisplay eglDisplay,725 QMirClientAppStateController *appState, EGLDisplay eglDisplay,
724 MirConnection *mirConnection, QMirClientDebugExtension *debugExt)726 MirConnection *mirConnection, QMirClientDebugExtension *debugExt)
@@ -735,6 +737,12 @@
735 , mScale(1.0)737 , mScale(1.0)
736 , mFormFactor(mir_form_factor_unknown)738 , mFormFactor(mir_form_factor_unknown)
737{739{
740 static bool metaTypeRegistered = false;
741 if (Q_UNLIKELY(!metaTypeRegistered)) {
742 qRegisterMetaType<QPlatformWindow*>();
743 metaTypeRegistered = true;
744 }
745
738 mWindowExposed = mSurface->mNeedsExposeCatchup == false;746 mWindowExposed = mSurface->mNeedsExposeCatchup == false;
739747
740 qCDebug(mirclient, "QMirClientWindow(window=%p, screen=%p, input=%p, surf=%p) with title '%s', role: '%d'",748 qCDebug(mirclient, "QMirClientWindow(window=%p, screen=%p, input=%p, surf=%p) with title '%s', role: '%d'",

Subscribers

People subscribed via source and target branches