Merge lp:~aacid/qtubuntu-sensors/temporary_open_file into lp:qtubuntu-sensors

Proposed by Albert Astals Cid
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 48
Merged at revision: 49
Proposed branch: lp:~aacid/qtubuntu-sensors/temporary_open_file
Merge into: lp:qtubuntu-sensors
Diff against target: 12 lines (+2/-1)
1 file modified
tests/test_sensor_api.cpp (+2/-1)
To merge this branch: bzr merge lp:~aacid/qtubuntu-sensors/temporary_open_file
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Timo Jyrinki Approve
Review via email: mp+202874@code.launchpad.net

Commit message

Q_ASSERT -> EXPECT_EQ

Since sometimes Q_ASSERT can be compiled out and thus the test would fail

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/test_sensor_api.cpp'
--- tests/test_sensor_api.cpp 2014-01-20 09:13:16 +0000
+++ tests/test_sensor_api.cpp 2014-01-23 14:48:56 +0000
@@ -54,7 +54,8 @@
54 protected:54 protected:
55 virtual void SetUp()55 virtual void SetUp()
56 {56 {
57 Q_ASSERT(data_file.open());57 bool openResult = data_file.open();
58 EXPECT_EQ(openResult, true);
58 setenv("UBUNTU_PLATFORM_API_SENSOR_TEST", qPrintable(data_file.fileName()), 1);59 setenv("UBUNTU_PLATFORM_API_SENSOR_TEST", qPrintable(data_file.fileName()), 1);
59 setenv("UBUNTU_PLATFORM_API_BACKEND", "libubuntu_application_api_test.so.1", 1);60 setenv("UBUNTU_PLATFORM_API_BACKEND", "libubuntu_application_api_test.so.1", 1);
6061

Subscribers

People subscribed via source and target branches