Code review comment for lp:~aacid/qtmir/remove_non_interface_things

Revision history for this message
Albert Astals Cid (aacid) wrote :

> > - qtmir::Application* findApplicationWithPid(const pid_t pid) const;
> > run this by Dednick, my memory suggests DBus menus require the pid. Though
> > probably not since it's not Q_INVOKABLE
>
> We dont use it for menus. We only use the "Surface Menus" (which use
> surfaceId)
> But we "may" need something in the future when we start using "Application
> Menus" (which use pid)

We can add it later if needed, in this branch i'm just removing functions we don't need to close the entry points for the branch that adds the mutex handling to ApplicationManager.

>
> >
> > Rest looks good!

« Back to merge proposal