Code review comment for lp:~aacid/qtmir/remove_non_interface_things

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> - qtmir::Application* findApplicationWithPid(const pid_t pid) const;
> run this by Dednick, my memory suggests DBus menus require the pid. Though
> probably not since it's not Q_INVOKABLE

We dont use it for menus. We only use the "Surface Menus" (which use surfaceId)
But we "may" need something in the future when we start using "Application Menus" (which use pid)

>
> Rest looks good!

« Back to merge proposal