Qt bindings for libbamf

Merge lp:~aacid/bamf-qt/constref into lp:bamf-qt

  1. constref
  2. Merge into trunk
Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 396
Merged at revision: 398
Proposed branch: lp:~aacid/bamf-qt/constref
Merge into: lp:bamf-qt
Diff against target: 129 lines (+10/-10)
10 files modified
bamf-application.cpp (+1/-1)
bamf-application.h (+1/-1)
bamf-factory.cpp (+1/-1)
bamf-factory.h (+1/-1)
bamf-indicator.cpp (+1/-1)
bamf-indicator.h (+1/-1)
bamf-view.cpp (+1/-1)
bamf-view.h (+1/-1)
bamf-window.cpp (+1/-1)
bamf-window.h (+1/-1)
To merge this branch: bzr merge lp:~aacid/bamf-qt/constref
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+103080@code.launchpad.net

Commit message

Add const & to some parameters

Avoids a copy of each object. It is true that most of those objects are
implicitly shared so the win isn't huge but we still save some atomic/mutex/something locking

Description of the change

Add const & to some parameters

Avoids a copy of each object. It is true that most of those objects are
implicitly shared so the win isn't huge but we still save some atomic/mutex/something locking

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bamf-application.cpp'
--- bamf-application.cpp 2011-01-13 21:37:10 +0000
+++ bamf-application.cpp 2012-04-23 11:41:18 +0000
@@ -22,7 +22,7 @@
22#include "bamf-application-proxy.h"22#include "bamf-application-proxy.h"
23#include "bamf-factory.h"23#include "bamf-factory.h"
2424
25BamfApplication::BamfApplication(QString path) :25BamfApplication::BamfApplication(const QString &path) :
26 BamfView(path), m_application_proxy(NULL)26 BamfView(path), m_application_proxy(NULL)
27{27{
28 m_application_proxy = new OrgAyatanaBamfApplicationInterface("org.ayatana.bamf", path,28 m_application_proxy = new OrgAyatanaBamfApplicationInterface("org.ayatana.bamf", path,
2929
=== modified file 'bamf-application.h'
--- bamf-application.h 2011-07-27 22:42:41 +0000
+++ bamf-application.h 2012-04-23 11:41:18 +0000
@@ -39,7 +39,7 @@
39friend class BamfFactory;39friend class BamfFactory;
4040
41private:41private:
42 BamfApplication(QString path);42 BamfApplication(const QString &path);
43 ~BamfApplication();43 ~BamfApplication();
44 BamfApplication(BamfApplication const&);44 BamfApplication(BamfApplication const&);
45 void operator=(BamfApplication const&);45 void operator=(BamfApplication const&);
4646
=== modified file 'bamf-factory.cpp'
--- bamf-factory.cpp 2012-04-13 14:48:10 +0000
+++ bamf-factory.cpp 2012-04-23 11:41:18 +0000
@@ -31,7 +31,7 @@
31}31}
3232
33BamfView *33BamfView *
34BamfFactory::view_for_path(QString path)34BamfFactory::view_for_path(const QString &path)
35{35{
36 if (path.isEmpty())36 if (path.isEmpty())
37 return NULL;37 return NULL;
3838
=== modified file 'bamf-factory.h'
--- bamf-factory.h 2011-07-27 22:42:41 +0000
+++ bamf-factory.h 2012-04-23 11:41:18 +0000
@@ -37,7 +37,7 @@
37 return instance;37 return instance;
38 }38 }
3939
40 BamfView * view_for_path(QString path);40 BamfView * view_for_path(const QString &path);
4141
42private:42private:
43 BamfFactory();43 BamfFactory();
4444
=== modified file 'bamf-indicator.cpp'
--- bamf-indicator.cpp 2011-01-31 10:16:00 +0000
+++ bamf-indicator.cpp 2012-04-23 11:41:18 +0000
@@ -22,7 +22,7 @@
22#include "bamf-indicator-proxy.h"22#include "bamf-indicator-proxy.h"
23#include "bamf-factory.h"23#include "bamf-factory.h"
2424
25BamfIndicator::BamfIndicator(QString path) :25BamfIndicator::BamfIndicator(const QString &path) :
26 BamfView(path), m_indicator_proxy(NULL)26 BamfView(path), m_indicator_proxy(NULL)
27{27{
28 m_indicator_proxy = new OrgAyatanaBamfIndicatorInterface("org.ayatana.bamf", path,28 m_indicator_proxy = new OrgAyatanaBamfIndicatorInterface("org.ayatana.bamf", path,
2929
=== modified file 'bamf-indicator.h'
--- bamf-indicator.h 2011-07-27 22:42:41 +0000
+++ bamf-indicator.h 2012-04-23 11:41:18 +0000
@@ -38,7 +38,7 @@
38friend class BamfFactory;38friend class BamfFactory;
3939
40private:40private:
41 BamfIndicator(QString path);41 BamfIndicator(const QString &path);
42 ~BamfIndicator();42 ~BamfIndicator();
43 BamfIndicator(BamfIndicator const&);43 BamfIndicator(BamfIndicator const&);
44 void operator=(BamfIndicator const&);44 void operator=(BamfIndicator const&);
4545
=== modified file 'bamf-view.cpp'
--- bamf-view.cpp 2010-12-21 09:56:42 +0000
+++ bamf-view.cpp 2012-04-23 11:41:18 +0000
@@ -22,7 +22,7 @@
22#include "bamf-view-proxy.h"22#include "bamf-view-proxy.h"
23#include "bamf-factory.h"23#include "bamf-factory.h"
2424
25BamfView::BamfView(QString path) :25BamfView::BamfView(const QString &path) :
26 m_proxy(NULL)26 m_proxy(NULL)
27{27{
28 m_proxy = new OrgAyatanaBamfViewInterface("org.ayatana.bamf", path,28 m_proxy = new OrgAyatanaBamfViewInterface("org.ayatana.bamf", path,
2929
=== modified file 'bamf-view.h'
--- bamf-view.h 2011-07-27 22:42:41 +0000
+++ bamf-view.h 2012-04-23 11:41:18 +0000
@@ -43,7 +43,7 @@
43friend class BamfFactory;43friend class BamfFactory;
4444
45protected:45protected:
46 BamfView(QString path);46 BamfView(const QString &path);
47 ~BamfView();47 ~BamfView();
4848
49private:49private:
5050
=== modified file 'bamf-window.cpp'
--- bamf-window.cpp 2011-01-13 21:37:10 +0000
+++ bamf-window.cpp 2012-04-23 11:41:18 +0000
@@ -22,7 +22,7 @@
22#include "bamf-window-proxy.h"22#include "bamf-window-proxy.h"
23#include "bamf-factory.h"23#include "bamf-factory.h"
2424
25BamfWindow::BamfWindow(QString path) :25BamfWindow::BamfWindow(const QString &path) :
26 BamfView(path), m_window_proxy(NULL)26 BamfView(path), m_window_proxy(NULL)
27{27{
28 m_window_proxy = new OrgAyatanaBamfWindowInterface("org.ayatana.bamf", path,28 m_window_proxy = new OrgAyatanaBamfWindowInterface("org.ayatana.bamf", path,
2929
=== modified file 'bamf-window.h'
--- bamf-window.h 2011-07-27 22:42:41 +0000
+++ bamf-window.h 2012-04-23 11:41:18 +0000
@@ -39,7 +39,7 @@
39friend class BamfFactory;39friend class BamfFactory;
4040
41private:41private:
42 BamfWindow(QString path);42 BamfWindow(const QString &path);
43 ~BamfWindow();43 ~BamfWindow();
44 BamfWindow(BamfWindow const&);44 BamfWindow(BamfWindow const&);
45 void operator=(BamfWindow const&);45 void operator=(BamfWindow const&);

Subscribers

People subscribed via source and target branches