Merge lp:~aacid/accounts-qml-module/negativeIndexRanges into lp:accounts-qml-module

[Albert Astals Cid]

Do not pass negative ranges to model calls

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:42
http://jenkins.qa.ubuntu.com/job/accounts-qml-module-ci/29/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/accounts-qml-module-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/accounts-qml-module-trusty-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/accounts-qml-module-trusty-armhf-ci/1/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/accounts-qml-module-ci/29/rebuild

review: Approve (continuous-integration)

[Alberto Mardegan (mardy)]

Oops! Thanks Albert, the change looks good! However, the upstream project is at:
http://code.google.com/p/accounts-sso/source/list?repo=accounts-qml-module

Could you please file a bug there and attach your patch? If not, just let me know and I'll do that.

[Albert Astals Cid (aacid)]

Send you an email with the patch, what should i do with this? Discard it?

review: Needs Information

[Alberto Mardegan (mardy)]

Yes please. I merged your changes upstream and now I'll bring them to launchpad:
https://code.launchpad.net/~mardy/accounts-qml-module/packaging/+merge/202942

Unmerged revisions

42. By Albert Astals Cid on 2014-01-23

Do not pass negative ranges to model calls

=== modified file 'src/account-service-model.cpp'
--- src/account-service-model.cpp	2013-11-13 11:48:31 +0000
+++ src/account-service-model.cpp	2014-01-23 10:19:48 +0000
@@ -285,7 +285,7 @@
     updateQueued = false;
     DEBUG();
 
-    q->beginRemoveRows(QModelIndex(), 0, modelItems.count() - 1);
+    q->beginRemoveRows(QModelIndex(), 0, qMax(0, modelItems.count() - 1));
     modelItems.clear();
     qDeleteAll(allItems);
     allItems.clear();
@@ -341,7 +341,7 @@
         }
     }
 
-    q->beginInsertRows(QModelIndex(), 0, newModelItems.count() - 1);
+    q->beginInsertRows(QModelIndex(), 0, qMax(0, newModelItems.count() - 1));
     modelItems = newModelItems;
     sortItems();
     q->endInsertRows();