kubuntu-packaging

Code review comment for ~a-volkov/kubuntu-packaging/+git/extra-cmake-modules:kubuntu_groovy_staging

  1. Git
  2. lp:~a-volkov/kubuntu-packaging/+git/extra-cmake-modules
  3. kubuntu_groovy_staging
  4. Merge into kubuntu_groovy_staging
Revision history for this message
Jose Manuel Santamaria Lema (panfaust) wrote :

NOTES (mostly for us, kubuntu devs reviewing the patch):

1. This change (move documentation to its own extra-cmake-modules-doc package) was included in the package from debian experimental src:extra-cmake-modules version 5.74.0-2

2. The package mentioned above is waiting in Debian's NEW queue: https://ftp-master.debian.org/new/extra-cmake-modules_5.74.0-2.html

3. In the source package mentioned above, extra-cmake-modules-doc declares a Breaks/Replaces against "extra-cmake-modules (>> 5.74.0-1)" I have the impression that this version is incorrect and the Breaks/Replaces should be declared against "extra-cmake-modules (>> 5.74.0-2)" because 5.74.0-2 would be the first package version in debian providing the split package.

4. Relevant commits from debian's git (in the order they were done):

https://salsa.debian.org/qt-kde-team/kde/extra-cmake-modules/-/commit/80bb8c1f6df1316adcc0b363f61195c89e374135

https://salsa.debian.org/qt-kde-team/kde/extra-cmake-modules/-/commit/c0865f8c7d38096c218ba8123e759f2f66f5895a

https://salsa.debian.org/qt-kde-team/kde/extra-cmake-modules/-/commit/8f77efe57e70d776c13e8710b0eb91a175df5cde

https://salsa.debian.org/qt-kde-team/kde/extra-cmake-modules/-/commit/81e87e653e8cb366da4b017929c98bf6628f1bec

https://salsa.debian.org/qt-kde-team/kde/extra-cmake-modules/-/commit/f491b24e8984506366c2b088a06f7b14ce6da858

« Back to merge proposal