Merge lp:~a-j-buxton/lightdm-gtk-greeter/clockleak into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Proposed by Alistair Buxton
Status: Merged
Merged at revision: 175
Proposed branch: lp:~a-j-buxton/lightdm-gtk-greeter/clockleak
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 20 lines (+4/-1)
1 file modified
src/lightdm-gtk-greeter.c (+4/-1)
To merge this branch: bzr merge lp:~a-j-buxton/lightdm-gtk-greeter/clockleak
Reviewer Review Type Date Requested Status
LightDM Gtk+ Greeter Development Team Pending
Review via email: mp+201074@code.launchpad.net

Commit message

Fix a memory leak in the clock timeout function.

Description of the change

The clock timeout function updates the label with the current time. The temporary string used to hold the time and markup should be freed after setting the label.

Fixes http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734526

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/lightdm-gtk-greeter.c'
--- src/lightdm-gtk-greeter.c 2014-01-09 02:35:27 +0000
+++ src/lightdm-gtk-greeter.c 2014-01-09 18:47:46 +0000
@@ -1732,12 +1732,15 @@
1732 time_t rawtime;1732 time_t rawtime;
1733 struct tm * timeinfo;1733 struct tm * timeinfo;
1734 gchar time_str[50];1734 gchar time_str[50];
1735 gchar *markup;
1735 1736
1736 time ( &rawtime );1737 time ( &rawtime );
1737 timeinfo = localtime ( &rawtime );1738 timeinfo = localtime ( &rawtime );
1738 1739
1739 strftime(time_str, 50, clock_format, timeinfo);1740 strftime(time_str, 50, clock_format, timeinfo);
1740 gtk_label_set_markup( GTK_LABEL(clock_label), g_strdup_printf("<b>%s</b>", time_str) );1741 markup = g_markup_printf_escaped("<b>%s</b>", time_str);
1742 gtk_label_set_markup( GTK_LABEL(clock_label), markup );
1743 g_free(markup);
1741 1744
1742 return TRUE;1745 return TRUE;
1743}1746}

Subscribers

People subscribed via source and target branches