Merge lp:~7-eric/inkscape/dbus-verbs into lp:~inkscape.dev/inkscape/trunk

[Eric Greveson]

Allow Object to Path verb from DBus interface in console mode

[Martin Owens (doctormo)]

Merging now, looks good and fairly simple.

review: Approve (code review)

=== modified file 'src/extension/internal/bluredge.cpp'
--- src/extension/internal/bluredge.cpp	2013-07-01 20:04:32 +0000
+++ src/extension/internal/bluredge.cpp	2013-08-12 15:49:10 +0000
@@ -94,7 +94,7 @@
 
             new_group->appendChild(new_items[i]);
             selection->add(new_items[i]);
-            sp_selected_path_to_curves(static_cast<SPDesktop *>(desktop));
+            sp_selected_path_to_curves(selection, static_cast<SPDesktop *>(desktop));
 
             if (offset < 0.0) {
                 /* Doing an inset here folks */
 
=== modified file 'src/path-chemistry.cpp'
--- src/path-chemistry.cpp	2013-05-01 05:46:14 +0000
+++ src/path-chemistry.cpp	2013-08-12 15:49:10 +0000
@@ -294,18 +294,16 @@
 
 /* This function is an entry point from GUI */
 void
-sp_selected_path_to_curves(SPDesktop *desktop, bool interactive)
+sp_selected_path_to_curves(Inkscape::Selection *selection, SPDesktop *desktop, bool interactive)
 {
-    Inkscape::Selection *selection = sp_desktop_selection(desktop);
-
     if (selection->isEmpty()) {
-        if (interactive)
+        if (interactive && desktop)
             sp_desktop_message_stack(desktop)->flash(Inkscape::WARNING_MESSAGE, _("Select <b>object(s)</b> to convert to path."));
         return;
     }
 
     bool did = false;
-    if (interactive) {
+    if (interactive && desktop) {
         desktop->messageStack()->flash(Inkscape::IMMEDIATE_MESSAGE, _("Converting objects to paths..."));
         // set "busy" cursor
         desktop->setWaitingCursor();
@@ -324,7 +322,7 @@
     g_slist_free (to_select);
     g_slist_free (selected);
 
-    if (interactive) {
+    if (interactive && desktop) {
         desktop->clearWaitingCursor();
         if (did) {
             DocumentUndo::done(sp_desktop_document(desktop), SP_VERB_OBJECT_TO_CURVE, 
 
=== modified file 'src/path-chemistry.h'
--- src/path-chemistry.h	2011-10-05 07:06:08 +0000
+++ src/path-chemistry.h	2013-08-12 15:49:10 +0000
@@ -19,6 +19,7 @@
 class SPItem;
 
 namespace Inkscape {
+class Selection;
 namespace XML {
 class Node;
 } // namespace XML
@@ -26,7 +27,8 @@
 
 void sp_selected_path_combine (SPDesktop *desktop);
 void sp_selected_path_break_apart (SPDesktop *desktop);
-void sp_selected_path_to_curves (SPDesktop *desktop, bool interactive = true);
+// interactive=true only has an effect if desktop != NULL, i.e. if a GUI is available
+void sp_selected_path_to_curves (Inkscape::Selection *selection, SPDesktop *desktop, bool interactive = true);
 void sp_selected_to_lpeitems(SPDesktop *desktop);
 Inkscape::XML::Node *sp_selected_item_to_curved_repr(SPItem *item, guint32 text_grouping_policy);
 void sp_selected_path_reverse (SPDesktop *desktop);
 
=== modified file 'src/ui/dialog/livepatheffect-editor.cpp'
--- src/ui/dialog/livepatheffect-editor.cpp	2013-08-03 21:09:02 +0000
+++ src/ui/dialog/livepatheffect-editor.cpp	2013-08-12 15:49:10 +0000
@@ -416,7 +416,7 @@
 
                 // If item is a SPRect, convert it to path first:
                 if ( SP_IS_RECT(item) ) {
-                    sp_selected_path_to_curves(current_desktop, false);
+                    sp_selected_path_to_curves(sel, current_desktop, false);
                     item = sel->singleItem(); // get new item
                 }
 
 
=== modified file 'src/verbs.cpp'
--- src/verbs.cpp	2013-07-23 10:54:01 +0000
+++ src/verbs.cpp	2013-08-12 15:49:10 +0000
@@ -1446,13 +1446,27 @@
  */
 void ObjectVerb::perform( SPAction *action, void *data)
 {
+    SPDesktop *dt = sp_action_get_desktop(action);
+    Inkscape::Selection *sel = sp_action_get_selection(action);
+
+    // We can perform some actions without a desktop
+    bool handled = true;
+    switch (reinterpret_cast<std::size_t>(data)) {
+        case SP_VERB_OBJECT_TO_CURVE:
+            sp_selected_path_to_curves(sel, dt);
+            break;
+        default:
+            handled = false;
+            break;
+    }
+    if (handled) {
+        return;
+    }
+
     g_return_if_fail(ensure_desktop_valid(action));
-    SPDesktop *dt = sp_action_get_desktop(action);
 
     SPEventContext *ec = dt->event_context;
 
-    Inkscape::Selection *sel = sp_desktop_selection(dt);
-
     if (sel->isEmpty())
         return;
 
@@ -1478,9 +1492,6 @@
         case SP_VERB_OBJECT_FLATTEN:
             sp_selection_remove_transform(dt);
             break;
-        case SP_VERB_OBJECT_TO_CURVE:
-            sp_selected_path_to_curves(dt);
-            break;
         case SP_VERB_OBJECT_FLOW_TEXT:
             text_flow_into_shape();
             break;