Code review comment for lp:~3v1n0/unity/trash-volumes-illumination
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
4d1350f
(Get the code!)
> Looks good, but what happens when you set the backlight to always on? Possibly
> make the indicator arrow 1 when its open?
I thought about that, but it could be confusing since it wouldn't be aware of the window position (monitor or workspace side), so I'd prefer to keep it in this way for now (in the worst case, there's no regression).
However the pips support is something I've alredy been working on and I've opened the bug #1161323 to track it.
> Also its no illuminated for me (like what happens when things are urgent),
> but im not sure if thats what you intended (I don't see it in the code).
This is what I meant by illumination: http://
Per se the trash/device icons would have a white background and I don't think this is what we want to see when they're opened.