Code review comment for lp:~3v1n0/unity/switcher-glowing-decorations

3026 lines (+1085/-455) 26 files modified

I hate you :)

1893 + typedef std::vector<LayoutWindow::Ptr> List;

You call it List but it's a vector. I really don't like it.

868 + if (launcher->Hidden() || launcher_hide_mode == LAUNCHER_HIDE_NEVER || launcher_hide_mode == LAUNCHER_HIDE_AUTOHIDE)

Does it makes sense? launcher_hide_mode can be LAUNCHER_HIDE_NEVER or LAUNCHER_HIDE_AUTOHIDE so this expression evaluates always true, right?

Bookmark: line 1068 (I'll continue the review later)

Please next time consider to have a different branch for style changes :)