Code review comment for lp:~3v1n0/unity/quicklist-on-expo.stable

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> > auto menus = Menus();
>
> I really don't like this idiom. Please provide a meaningful name for the type
> std::list<DbusmenuMenuitem*> rather than use auto.

Ok, I've reverted the type for this one.

> > auto win_manager = WindowManager::Default();
>
> Here too. Please lets not abuse auto.

I this case I've not removed the auto. I don't think that I'm abusing of it in this case since we're retrieving something that has a very explicit type also reading the right-hand operator...
So I'd keep it here.

« Back to merge proposal