Unity

Merge lp:~3v1n0/unity/panel-controller-signals-disconnect into lp:unity

  1. panel-controller-signals-disconnect
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 4252
Proposed branch: lp:~3v1n0/unity/panel-controller-signals-disconnect
Merge into: lp:unity
Prerequisite: lp:~3v1n0/unity/lowgfx-setting-sync
Diff against target: 13 lines (+1/-2)
1 file modified
panel/PanelController.cpp (+1/-2)
To merge this branch: bzr merge lp:~3v1n0/unity/panel-controller-signals-disconnect
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+327862@code.launchpad.net

Commit message

PanelController: ensure we disconnect from signals on destruction

It's just about using the magic of deriving from sigc::trackable.
Since UScreen might be late in signaling screen changes it could fail

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

--1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'panel/PanelController.cpp'
--- panel/PanelController.cpp 2014-07-30 00:49:35 +0000
+++ panel/PanelController.cpp 2017-07-21 08:59:28 +0000
@@ -33,9 +33,8 @@
3333
34const char* window_title = "unity-panel";34const char* window_title = "unity-panel";
3535
36class Controller::Impl36struct Controller::Impl : sigc::trackable
37{37{
38public:
39 Impl(Controller*, menu::Manager::Ptr const&, ui::EdgeBarrierController::Ptr const&);38 Impl(Controller*, menu::Manager::Ptr const&, ui::EdgeBarrierController::Ptr const&);
40 ~Impl();39 ~Impl();
4140