Merge lp:~3v1n0/unity/panel-controller-signals-disconnect into lp:unity

Proposed by Marco Trevisan (Treviño) on 2017-07-21
Status: Merged
Approved by: Andrea Azzarone on 2017-07-21
Approved revision: 4264
Merged at revision: 4252
Proposed branch: lp:~3v1n0/unity/panel-controller-signals-disconnect
Merge into: lp:unity
Prerequisite: lp:~3v1n0/unity/lowgfx-setting-sync
Diff against target: 13 lines (+1/-2)
1 file modified
panel/PanelController.cpp (+1/-2)
To merge this branch: bzr merge lp:~3v1n0/unity/panel-controller-signals-disconnect
Reviewer Review Type Date Requested Status
Andrea Azzarone 2017-07-21 Approve on 2017-07-21
Review via email: mp+327862@code.launchpad.net

Commit message

PanelController: ensure we disconnect from signals on destruction

It's just about using the magic of deriving from sigc::trackable.
Since UScreen might be late in signaling screen changes it could fail

To post a comment you must log in.
Andrea Azzarone (azzar1) wrote :

--1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panel/PanelController.cpp'
2--- panel/PanelController.cpp 2014-07-30 00:49:35 +0000
3+++ panel/PanelController.cpp 2017-07-21 08:59:28 +0000
4@@ -33,9 +33,8 @@
5
6 const char* window_title = "unity-panel";
7
8-class Controller::Impl
9+struct Controller::Impl : sigc::trackable
10 {
11-public:
12 Impl(Controller*, menu::Manager::Ptr const&, ui::EdgeBarrierController::Ptr const&);
13 ~Impl();
14