Code review comment for lp:~3v1n0/unity/launcher-draggable-icons

Revision history for this message
Andrea Azzarone (azzar1) wrote :

1959 - uscreen->resuming.connect([&]() -> void {
1960 - for (auto launcher : launchers)
1961 - launcher->QueueDraw();
1962 - });

Why have you removed this code?

In volume VolumeLauncherIcon you are calling parent_->UnStick(); before TryToUnblacklist. I think you should call it when you receive the changed signal from device_settings.

+ void Stick(bool save = true);

You should not use default values for virtual function (consider NVI to fix this "issue").

200 +#ifndef TEST_MOCK_DEVICES_H
4201 +#define TEST_MOCK_DEVICES_H

Why do you need this guards?

« Back to merge proposal