> 183 data->proxy = proxy_;
>
> Makes me sad that it doesn't use the dbus proxy class from unity core.
Yes, you're right.
Unfortunately that code was written before it was available I guess, so I just didn't rewrite the whole thing.
I see if that's quickly feasible ;)
> 194 + g_idle_add_full (G_PRIORITY_DEFAULT, (GSourceFunc) send_show_entry,
> data, NULL);
>
> Moreover this is pretty dangerous, it should at least grab a ref on the proxy.
> Alternatively such timeouts should be removed in the destructor.
Sure, again... I just followed the old school! :)
> 1114 +#include <fcntl.h>
>
> I hope this isn't needed?
> 183 data->proxy = proxy_;
>
> Makes me sad that it doesn't use the dbus proxy class from unity core.
Yes, you're right.
Unfortunately that code was written before it was available I guess, so I just didn't rewrite the whole thing.
I see if that's quickly feasible ;)
> 194 + g_idle_add_full (G_PRIORITY_ DEFAULT, (GSourceFunc) send_show_entry,
> data, NULL);
>
> Moreover this is pretty dangerous, it should at least grab a ref on the proxy.
> Alternatively such timeouts should be removed in the destructor.
Sure, again... I just followed the old school! :)
> 1114 +#include <fcntl.h>
>
> I hope this isn't needed?
Yes, no more needed. /me cleaning it.