Code review comment for lp:~3v1n0/unity/globalmenu-discovery-new-apps

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> What is the _new_apps for exactly? std::list is fine if you are going to be
> constantly adding and removing items, but if speed is needed more often than
> addition or removal then std::vector is better due to cache-coherency. If
> there are a lot of items, perhaps std::set is better.

This is a list of new launched applications. Generally that is just containing one item, but if you quickly launch many applications together (i.e. you're doing something like "nautilus & baobab & gedit & shotwell &" in your terminal) we need to check that once one of the new applications has been focused, its menus are shown.
Using just a pointer for that is not good, otherwise we would control only the last opened application.

« Back to merge proposal