Merge lp:~3v1n0/unity/desktop-utilities-unescape-paths into lp:unity
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Michal Hruby |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2801 |
Proposed branch: | lp:~3v1n0/unity/desktop-utilities-unescape-paths |
Merge into: | lp:unity |
Diff against target: |
97 lines (+33/-9) 2 files modified
UnityCore/DesktopUtilities.cpp (+18/-6) tests/test_desktop_utilities.cpp (+15/-3) |
To merge this branch: | bzr merge lp:~3v1n0/unity/desktop-utilities-unescape-paths |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Approve | ||
Review via email: mp+127590@code.launchpad.net |
Commit message
DesktopUtilities: unescape the desktop paths and ids before processing them
Description of the change
When computing the DesktopID or the file path from a DesktopID, we need to make sure that the processed file has been escaped.
Unit tests added.
To post a comment you must log in.
Is this really what we want to do? We should properly distinguish methods that accept paths vs methods that work with URIs. Otherwise the next bug we'll get is "Unable to add desktop files with [insert special symbol here] in their name".