Looks good to me. I ran the autopilot tests and all but 10 passed (an those 10 failures weren't obviously related to this branch).
It would be good to have someone else familiar with the code (i.e. on the unity team) to approve this code too.
I see there are no tests with this fix, I understand there isn't any testing for this area already setup and thus would be a bit of a commitment.
Perhaps if some of the tests were updated to use select_single/select_many + attribute selections that could add a small amount of coverage (as it's actively exercising this code).
Looks good to me. I ran the autopilot tests and all but 10 passed (an those 10 failures weren't obviously related to this branch).
It would be good to have someone else familiar with the code (i.e. on the unity team) to approve this code too.
I see there are no tests with this fix, I understand there isn't any testing for this area already setup and thus would be a bit of a commitment. single/ select_ many + attribute selections that could add a small amount of coverage (as it's actively exercising this code).
Perhaps if some of the tests were updated to use select_