Code review comment for lp:~3v1n0/unity/dbus-indicators-proxy

Revision history for this message
Michal Hruby (mhr3) wrote :

787 + bool auto_reconnect)

What are you actually trying to achieve with this? GDBusProxy automatically reconnects itself if you construct it using a known service name (as opposed to unique bus address). Therefore it seems redundant to me.

If you want to make sure that a service is alive, all you need to do is watch changes to the connected state and if it disconnects, just call any method from given interface and that will dbus-activate the service again.

review: Needs Information

« Back to merge proposal