Merge lp:~3v1n0/unity/cancellable-volume-6.0 into lp:unity/6.0

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 2775
Proposed branch: lp:~3v1n0/unity/cancellable-volume-6.0
Merge into: lp:unity/6.0
Diff against target: 39 lines (+4/-4)
1 file modified
launcher/VolumeImp.cpp (+4/-4)
To merge this branch: bzr merge lp:~3v1n0/unity/cancellable-volume-6.0
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
Review via email: mp+128705@code.launchpad.net

Commit message

VolumeImp: use GCancellable to perform glib async operations

Description of the change

To post a comment you must log in.
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

LGTM

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1518/console reported an error when processing this lp:~3v1n0/unity/cancellable-volume-6.0 branch.
Not merging it.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1519/console reported an error when processing this lp:~3v1n0/unity/cancellable-volume-6.0 branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'launcher/VolumeImp.cpp'
--- launcher/VolumeImp.cpp 2012-10-02 17:09:55 +0000
+++ launcher/VolumeImp.cpp 2012-10-09 13:31:25 +0000
@@ -127,7 +127,7 @@
127 g_volume_eject_with_operation(volume_,127 g_volume_eject_with_operation(volume_,
128 (GMountUnmountFlags)0,128 (GMountUnmountFlags)0,
129 mount_op,129 mount_op,
130 nullptr,130 cancellable_,
131 (GAsyncReadyCallback)OnEjectReady,131 (GAsyncReadyCallback)OnEjectReady,
132 this);132 this);
133 }133 }
@@ -155,7 +155,7 @@
155 g_volume_mount(volume_,155 g_volume_mount(volume_,
156 (GMountMountFlags) 0,156 (GMountMountFlags) 0,
157 mount_op,157 mount_op,
158 nullptr,158 cancellable_,
159 (GAsyncReadyCallback) &Impl::OnMountFinish,159 (GAsyncReadyCallback) &Impl::OnMountFinish,
160 this);160 this);
161 }161 }
@@ -195,7 +195,7 @@
195 g_drive_stop(drive,195 g_drive_stop(drive,
196 (GMountUnmountFlags)0,196 (GMountUnmountFlags)0,
197 mount_op,197 mount_op,
198 nullptr, nullptr, nullptr);198 cancellable_, nullptr, nullptr);
199 }199 }
200200
201 void Unmount()201 void Unmount()
@@ -209,7 +209,7 @@
209 g_mount_unmount_with_operation(mount,209 g_mount_unmount_with_operation(mount,
210 (GMountUnmountFlags)0,210 (GMountUnmountFlags)0,
211 op,211 op,
212 nullptr, nullptr, nullptr);212 cancellable_, nullptr, nullptr);
213 }213 }
214214
215 VolumeImp* parent_;215 VolumeImp* parent_;

Subscribers

People subscribed via source and target branches