Code review comment for lp:~3v1n0/unity-settings-daemon/kbd-brightness-update

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> what would happen if that landed/was used without the upower patch? if the
> patch is needed to avoid a regression we need to wait for upower to be
> uploaded and update the depends

Simply nothing.

If the upower change doesn't land or is delayed, the fix just doesn't work since upower will always return the cached brightness value on upower_kbd_update_brightness call, then this patch is quite useless (but not dangerous) in that case.

So, there's not much need of bumping the required versions, although this could ensure the fix will land alltogether.
Just let me know what you prefer.

« Back to merge proposal