Code review comment for lp:~3v1n0/unity-greeter/shutdown-average-color-bg

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> This should be in BackgroundLoader.load:
> 8 + if (current_background[0] == '#' && current_background.length <= 7)
> 9 + {
> 10 + Gdk.Color c;
> 11 + Gdk.Color.parse (current_background, out c);
> 12 + current.average_color = {c.red/65535.0f, c.green/65535.0f,
> c.blue/65535.0f, 1.0f};
> 13 + }

Right... It was just an hack for my tests, then I left it there without noticing that it was just about to add one line into the loader... :)

> You should probably use a property instead of a method for get_average_color

As you prefer...

Fixed both.

« Back to merge proposal