Ubuntu
bamf package

Code review comment for lp:~3v1n0/ubuntu/oneiric/bamf/libreoffice-fixes

  1. Oneiric (11.10)
  2. libreoffice-fixes
  3. Merge into oneiric
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

As discussed on IRC:

1. unfortunately defining a test case is a little bit hard since this bug is mostly related to a race in BamfDaemon, that when libreoffice is opened and shows its splash-screen, and quickly closes it, causes the new opening libreoffice window to be considered as closed as well making our maching code not to work.
So, for sure a test case would be:

1) Enable the splash screen in libreoffice
2) Launch libreoffice double-cliking on a lo file
3) Repeat this action multiple times and the bug should manifest.

2. The first lines of this patch changes handle_window_closed() in bamf-legacy-window.c, that function is called every time that a window is closed, but the only field I'm in fact changing is the private member is_closed. This value can only be read and is only used by the bamf_legacy_window_is_closed() function, and this function is actually used in BAMF only by the matcher code that is used only for LO windows.
So, the bug is clear, the code I'm fixing is only affecting and used by LO windows, so we should be safe about regressions.

« Back to merge proposal