Code review comment for lp:~3v1n0/ubuntu/oneiric/bamf/libreoffice-fixes

Revision history for this message
David Barth (dbarth) wrote :

To prepare the fix for an SRU upload:

1. Can you highlight the test case that would accompany this sru fix? Most probably there is already a comment in the bug report; it should go into a manual-test/openoffice.txt text file describing the steps to reproduce the issue and verify that the problem is solved with the fix

2. More importantly, when looking at the start of the patch; can you think of a few regressions test case, to verify that even if a non-LO window is managed by the new code, then the code in line 23-29 of your patch will still do the right thing

review: Needs Information

« Back to merge proposal