Ubuntu
gnome-shell package

Code review comment for ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master-xubuntu-cancel-search

  1. Git
  2. lp:~3v1n0/ubuntu/+source/gnome-shell
  3. ubuntu/master-xubuntu-cancel-search
  4. Merge into ubuntu/master
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

> I saw that you made some changes on the MR after Florian's comment on your
> patches. Is there anything you can borrow and refresh here?

Yes, I wanted to refresh in case a review (like in this case) was coming in time, so nothing functional has been changed there, but I can refresh it on that.

As per the two questions, let me know if you want get rid of that variable or use a property bound to the cancellable instead.

« Back to merge proposal