Code review comment for ~3v1n0/ubuntu/+source/gnome-calculator:ubuntu/master-xubuntu-cancel-search

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

From IRC:
Trevinho: https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-calculator/+git/gnome-calculator/+merge/353828/comments/921762 as well
Trevinho: have you just repushed another commit with the initial date staying the same? (hard to know with launchpad MP UI)
which sounds like from the diff
ah interesting, you can switch the diff and you see the the new diff was generated on the 30 while the commit is still on the 28… (but no evidence that you pushed a new
commit)
quite confusing, used to gitlab/github when you see something else was pushed and overrides

looks good to approve now then!

review: Approve

« Back to merge proposal