Code review comment for lp:~3v1n0/ubuntu-themes/suggested-action-states-fix

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I think dark is a bad choice. Dark looks either disabled or depressed, when neither of those are true.

Hover highlighting I think should be light, at least for dark backgrounds like the Ambiance headerbar. Hovering over something should always increase its contrast with the background. So in that case it's the grey buttons I would like to see lighter when hovered. :)

I'm fairly confident most designers would agree with what I just said.

P.S. I don't understand what Didier is saying but don't need to if we both agree on Disapprove.

review: Disapprove

« Back to merge proposal