Code review comment for lp:~3v1n0/ubuntu-themes/list-theming

As also said on IRC, g-c-c is the worse example where to test such changes, as it embeds a theme change which would override these changes.

So these fixes should be landed together with the debdiff included here:
 https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1757471

> (1) Alternating background (every second item) is the same colour as the
> selection.

Thank for pointing out, I've fixed this case. Now we use a darker hover color when using the zebra-lists.

> (2) Text colour is white on light grey (unreadable).

Fixed.

> And pre-existing bugs should be fixed but aren't:
>
> (3) Some list items (like the monitor name in Settings > Color) never
> highlight. Works in Adwaita.
> (3) I mean the hover effect is missing in Settings > Color

This is fixed here, but the theme override won't show it.

> (4) List in bubble menus (Settings > Displays > Resolution etc) are a mixture
> of grey and white backgrounds.

Works here. Again, after removing the g-c-c patch.

> (5) The background area around the Settings > Color > 'Add profile' and
> 'Calibrate' buttons is still missing in Ambiance (but not in Adwaita).

Thanks, this is a different part of the theme which wasn't covered at all.
I've fixed this too.