Merge lp:~3v1n0/ubuntu-themes/fix-dialog-headerbar-min-height into lp:ubuntu-themes

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Iain Lane
Approved revision: 568
Merged at revision: 565
Proposed branch: lp:~3v1n0/ubuntu-themes/fix-dialog-headerbar-min-height
Merge into: lp:ubuntu-themes
Prerequisite: lp:~3v1n0/ubuntu-themes/vertical-linked-buttons-tuning
Diff against target: 32 lines (+4/-8)
2 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+2/-4)
Radiance/gtk-3.20/gtk-widgets.css (+2/-4)
To merge this branch: bzr merge lp:~3v1n0/ubuntu-themes/fix-dialog-headerbar-min-height
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+331197@code.launchpad.net

Commit message

Ambiance, Radiance: be less restrictive in setting headerbar minimum height

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

Seems good, might be worth a quick grep in gtk to see that titlebar isn't added in other situations (not sure why it was limited like that).

Thanks!

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

It was limited in that way, since so it was also in Adwaita... Then upstream changed a bit the things.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
--- Ambiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
+++ Ambiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
@@ -2152,10 +2152,8 @@
2152 border-radius: 0;2152 border-radius: 0;
2153}2153}
21542154
2155.default-decoration.titlebar:not(headerbar),2155.titlebar:not(headerbar),
2156messagedialog.csd .titlebar:not(headerbar),2156headerbar {
2157messagedialog.solid-csd .titlebar:not(headerbar),
2158headerbar.default-decoration {
2159 min-height: 26px;2157 min-height: 26px;
2160}2158}
21612159
21622160
=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
--- Radiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
+++ Radiance/gtk-3.20/gtk-widgets.css 2017-09-22 14:26:48 +0000
@@ -2151,10 +2151,8 @@
2151 border-radius: 0;2151 border-radius: 0;
2152}2152}
21532153
2154.default-decoration.titlebar:not(headerbar),2154.titlebar:not(headerbar),
2155messagedialog.csd .titlebar:not(headerbar),2155headerbar {
2156messagedialog.solid-csd .titlebar:not(headerbar),
2157headerbar.default-decoration {
2158 min-height: 26px;2156 min-height: 26px;
2159}2157}
21602158

Subscribers

People subscribed via source and target branches