Code review comment for lp:~3v1n0/ubuntu-settings-components/slots-layouts

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> Nice, much better.
>
> Why is the text on "Charge level" in Battery darker than other text?

Well, this is what we get from the model:

      label: Charge level
      sensitive: false
      isSeparator: false
      icon:
      type: com.canonical.indicator.progress
      ext:
      action: indicator.battery-level
      actionState: 100
      isCheck: false
      isRadio: false
      isToggled: false

Thus the "sensitive: false" thing causes the "enabled" property to be set to false. This is done in MenuItemFactory in unity8.

In that case, as you can see in BaseLayoutMenu the title's opacity is set to 0.5.
I think that's correct in normal state...

However I can easily fix this at U8 level by hacking it with: http://pastebin.ubuntu.com/23210930/ (I'm cleaning up some stuff in u8 anyway)

« Back to merge proposal