Code review comment for lp:~3v1n0/ubuntu-settings-components/slots-layouts

Revision history for this message
Michael Terry (mterry) wrote :

I started poking at this, I know you're not marked for review yet. Mainly I just compared old and new examples/ and had a few comments:

- I assume the lighter text color and indented menu content is from the switched SDK element, not something explicitly done?

- ButtonMenu seems to have swapped its button location with "SlotsLayout.position: SlotsLayout.Leading" instead of trailing.

- I know it's a little more consistent with behavior elsewhere, but having to swipe-right-then-press-the-delete-button is a bit more annoying than merely swipe-right on the Messaging Menu when you have a couple messages to clear (and you don't want to clear ALL the messages with the "clear all" button). Is design aware of that potential change? Actually, how involved is design in this MP in general? I know most of it makes 100% sense (using proper new SDK elements is always good), but there will be some inevitable UI differences.

- Why is the width of 'qmlscene examples/SettingsComponents.qml' set correctly on trunk but not on this MP?

I love that every gosh dang menu item no longer has a divider by default.

« Back to merge proposal