Merge lp:~3v1n0/libindicator/shortcut-nicks-startup-notify-13.04 into lp:libindicator/13.04

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 485
Merged at revision: 486
Proposed branch: lp:~3v1n0/libindicator/shortcut-nicks-startup-notify-13.04
Merge into: lp:libindicator/13.04
Diff against target: 57 lines (+19/-5)
1 file modified
libindicator/indicator-desktop-shortcuts.c (+19/-5)
To merge this branch: bzr merge lp:~3v1n0/libindicator/shortcut-nicks-startup-notify-13.04
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Mathieu Trudel-Lapierre Approve
Review via email: mp+157787@code.launchpad.net

Commit message

IndicatorDestkopShortcuts: add StartupNotify parameter in our internal fake .desktop file

Otherwise GAppInfo won't pass the relevant platform-data to the Application launched.
Plus, fix the docs.

Description of the change

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libindicator/indicator-desktop-shortcuts.c'
--- libindicator/indicator-desktop-shortcuts.c 2013-04-05 11:03:41 +0000
+++ libindicator/indicator-desktop-shortcuts.c 2013-04-09 03:03:22 +0000
@@ -555,9 +555,10 @@
555}555}
556556
557/**557/**
558 indicator_desktop_shortcuts_nick_exec:558 indicator_desktop_shortcuts_nick_exec_with_context:
559 @ids: The #IndicatorDesktopShortcuts object to look in559 @ids: The #IndicatorDesktopShortcuts object to look in
560 @nick: Which command that we're referencing.560 @nick: Which command that we're referencing.
561 @launch_context: The #GAppLaunchContext to use for launching the shortcut
561562
562 Here we take a @nick and try and execute the action that is563 Here we take a @nick and try and execute the action that is
563 associated with it. The @nick parameter should be gotten564 associated with it. The @nick parameter should be gotten
@@ -630,9 +631,9 @@
630 gchar * desktopdata = g_strdup_printf("[" G_KEY_FILE_DESKTOP_GROUP "]\n"631 gchar * desktopdata = g_strdup_printf("[" G_KEY_FILE_DESKTOP_GROUP "]\n"
631 G_KEY_FILE_DESKTOP_KEY_TYPE "=" G_KEY_FILE_DESKTOP_TYPE_APPLICATION "\n"632 G_KEY_FILE_DESKTOP_KEY_TYPE "=" G_KEY_FILE_DESKTOP_TYPE_APPLICATION "\n"
632 G_KEY_FILE_DESKTOP_KEY_NAME "=%s\n"633 G_KEY_FILE_DESKTOP_KEY_NAME "=%s\n"
633 G_KEY_FILE_DESKTOP_KEY_EXEC "=%s\n",634 G_KEY_FILE_DESKTOP_KEY_EXEC "=%s\n"
634 name, exec);635 G_KEY_FILE_DESKTOP_KEY_STARTUP_NOTIFY "=%s\n",
635 636 name, exec, launch_context ? "true" : "false");
636637
637 g_free(name); g_free(exec);638 g_free(name); g_free(exec);
638 /* g_debug("Desktop file: \n%s", desktopdata); */639 /* g_debug("Desktop file: \n%s", desktopdata); */
@@ -653,7 +654,6 @@
653 g_key_file_free(launcher);654 g_key_file_free(launcher);
654 return FALSE;655 return FALSE;
655 }656 }
656
657 gboolean launched = g_app_info_launch(G_APP_INFO(appinfo), NULL, launch_context, &error);657 gboolean launched = g_app_info_launch(G_APP_INFO(appinfo), NULL, launch_context, &error);
658658
659 if (error != NULL) {659 if (error != NULL) {
@@ -669,6 +669,20 @@
669 return launched;669 return launched;
670}670}
671671
672/**
673 indicator_desktop_shortcuts_nick_exec:
674 @ids: The #IndicatorDesktopShortcuts object to look in
675 @nick: Which command that we're referencing.
676
677 Here we take a @nick and try and execute the action that is
678 associated with it. The @nick parameter should be gotten
679 from #indicator_desktop_shortcuts_get_nicks though it's not
680 required that the exact memory location be the same.
681 This function is deprecated and shouldn't be used in newly
682 written code.
683
684 Return value: #TRUE on success or #FALSE on error.
685*/
672gboolean686gboolean
673indicator_desktop_shortcuts_nick_exec (IndicatorDesktopShortcuts * ids, const gchar * nick)687indicator_desktop_shortcuts_nick_exec (IndicatorDesktopShortcuts * ids, const gchar * nick)
674{688{

Subscribers

People subscribed via source and target branches