Code review comment for lp:~3v1n0/libappindicator/scroll-event-support

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> http://www.notmart.org/misc/statusnotifieritem/statusnotifieritem.html#Scroll
>
> Same as indicator-application, should export the SNI method.

Ok, I'll do it.

> I also don't understand this code:
>
> 117 +
> 118 + char * name = g_dbus_proxy_get_name_owner(app->priv->watcher_proxy);
> 119 + if (name != NULL) {
> 120 + g_free(name);
> 121 + }
> Why is the name being gotten here?

Oops, it was for debugging, I'll move it away.

> Lastly the reserved don't need to be taken away when there is already a slot
> reserved for it. You're taking away from the class structure twice:
>
> - void (*app_indicator_reserved_6)(void);

That's true... I removed it at the beginning, since I didn't know which one use. I'll reset it.

« Back to merge proposal