Merge lp:~3v1n0/compiz/unity-wm-shortcuts-0.9.10 into lp:compiz/0.9.11

Proposed by Marco Trevisan (Treviño)
Status: Superseded
Proposed branch: lp:~3v1n0/compiz/unity-wm-shortcuts-0.9.10
Merge into: lp:compiz/0.9.11
Diff against target: 1598 lines (+1409/-130) (has conflicts)
5 files modified
debian/changelog (+1357/-3)
debian/control (+8/-0)
debian/patches/series (+0/-1)
debian/patches/ubuntu-config.patch (+44/-36)
debian/patches/unity_support_test.patch (+0/-90)
Text conflict in debian/control
Text conflict in debian/patches/ubuntu-config.patch
To merge this branch: bzr merge lp:~3v1n0/compiz/unity-wm-shortcuts-0.9.10
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+185822@code.launchpad.net

Commit message

debian/patches/ubuntu-config.patch: remove grid custom keybindings for window management

We handle these directly in unity

To post a comment you must log in.
3789. By Marco Trevisan (Treviño)

debian/patches/ubuntu-config.patch: remove grid custom keybindings for window management

We handle these directly in unity

Unmerged revisions

3789. By Marco Trevisan (Treviño)

debian/patches/ubuntu-config.patch: remove grid custom keybindings for window management

We handle these directly in unity

3788. By Christopher Townsend

Alt-Tabbing or Launcher selecting a window that is over 50% in a different viewport should not switch the viewport nor change the placement of the window. The fix is to add an option to turn this behavior on or off. By default, the option is on, but Ubuntu is patched to turn it off to fix this bug. Fixes: https://bugs.launchpad.net/bugs/1092323.

Approved by Brandon Schaefer, PS Jenkins bot.

3787. By Christopher Townsend

Work done by Sam Spilsbury:
- Ensure that the frame region is always set as soon as the window is decorated.
- Further ensure that the window decoration isn't needlessly reset if the window already had one.
- Refactored XShape usage into a common function.
- Added tests to verify the behaviour of shape set on initially creating a decorated window and also upon changing the input frame window shape. Fixes: https://bugs.launchpad.net/bugs/1158267.

Approved by Brandon Schaefer, PS Jenkins bot.

3786. By PS Jenkins bot

Releasing 1:0.9.10+13.10.20130828.2-0ubuntu1 (revision 3785 from lp:compiz/0.9.10).

Approved by PS Jenkins bot.

3785. By Łukasz Zemczak

Fix the Replaces/Breaks version in the default plugin

3784. By Christopher Townsend

Ctrl-Alt-Del should open the gnome-system-monitor at the processes tab. This fix uses the commands plugin to override the default action. This includes:
 - Install the commands plugin by default.
 - Breaks/Replaces the compiz-plugins package for versions earlier than 0.9.10.
 - Patch commands.xml and integrated.xml to map gnome-system-monitor to Ctrl-Alt-Del by default.
 - Start the command plugin upon Compiz starting. Fixes: https://bugs.launchpad.net/bugs/890747.

Approved by PS Jenkins bot, Brandon Schaefer.

3783. By Christopher Townsend

Removed logic in the calculateWallOffset() function in the Expo plugin that only accounted for offsetting the expo animation on the left-most and top-most monitor. Also removed the TestNoOffsetIfOutputIsNotOrigin test since this test is now invalid. Fixes: https://bugs.launchpad.net/bugs/1031710.

Approved by Brandon Schaefer, PS Jenkins bot.

3782. By PS Jenkins bot

Releasing 1:0.9.10+13.10.20130822-0ubuntu1 (revision 3781 from lp:compiz/0.9.10).

Approved by PS Jenkins bot.

3781. By Łukasz Zemczak

Merge in saucy-released changelog, prepare revision to start off from with the new daily-release

3780. By Łukasz Zemczak

Remove the unity support test patch, we don't need it - also, the version in saucy already has this patch removed.

Approved by PS Jenkins bot, Andrea Azzarone.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-06-01 00:10:24 +0000
+++ debian/changelog 2013-09-16 14:44:07 +0000
@@ -1,8 +1,1362 @@
1compiz (1:0.9.10-0ubuntu1) UNRELEASED; urgency=low1compiz (1:0.9.10+13.10.20130828.2-0ubuntu1) saucy; urgency=low
22
3 [ Chris Townsend ]
4 * Removed logic in the calculateWallOffset() function in the Expo
5 plugin that only accounted for offsetting the expo animation on the
6 left-most and top-most monitor. Also removed the
7 TestNoOffsetIfOutputIsNotOrigin test since this test is now invalid.
8 (LP: #1031710)
9 * Ctrl-Alt-Del should open the gnome-system-monitor at the processes
10 tab. This fix uses the commands plugin to override the default
11 action. This includes: - Install the commands plugin by default. -
12 Breaks/Replaces the compiz-plugins package for versions earlier than
13 0.9.10. - Patch commands.xml and integrated.xml to map gnome-system-
14 monitor to Ctrl-Alt-Del by default. - Start the command plugin upon
15 Compiz starting. (LP: #890747)
16
17 [ Łukasz 'sil2100' Zemczak ]
18 * Fix the Replaces/Breaks version in the default plugin
19
20 [ Ubuntu daily release ]
21 * Automatic snapshot from revision 3785
22
23 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 28 Aug 2013 19:13:51 +0000
24
25compiz (1:0.9.10+13.10.20130822-0ubuntu1) saucy; urgency=low
26
27 [ Sam Spilsbury ]
3 * Bump version to 0.9.1028 * Bump version to 0.9.10
429
5 -- Sam Spilsbury <smspillaz@interpol> Thu, 25 Apr 2013 11:13:32 +080030 [ Łukasz 'sil2100' Zemczak ]
31 * Remove debian/patches/unity_support_test.patch:
32 - Running the support test from compiz has bad side effects, from now
33 on we run it from Xsession.d
34 * Automatic snapshot from revision 3644
35
36 [ Iven Hsu ]
37 * Opacify: Only dim the windows above the active window.(LP:
38 #1189374). (LP: #1189374)
39 * KWD: Fix compile errors with KDE 4.11. The KWin developers made
40 kdecorationbridge.h private. See:
41 http://lists.freedesktop.org/archives/compiz/2013-March/003479.html
42 (LP: #1193792). (LP: #1193792)
43
44 [ Nikolay Martynov ]
45 * When static switcher is enabled and has an option to show
46 application icon turned on the icons are expected to be ~1/3 of a
47 thumbnail (48px). Instead they are displayed in 512px size and
48 completely cover everything. This change addresses this issue. See
49 LP #1173914. (LP: #1173914, #1186426)
50
51 [ BryanFRitt ]
52 * Fixed the non-working Annotate 'Clear' Button. Moved this option's
53 CCSM position upwards to keep the button shortcuts together. (LP:
54 #1202907). (LP: #1202907)
55
56 [ Mehrdad Afshari ]
57 * Added "move window to previous monitor" feature to compiz Put
58 plugin. (LP: #1178581)
59
60 [ Hu Kang ]
61 * gtk-window-decorator: destroy action menu when any of the (close,
62 min, max) buttons on the title bar is pressed. (LP: #1101648)
63 * Remove redundant src/logmessage/include/core/logmessage.h (LP:
64 #1067246). (LP: #1067246)
65
66 [ Steve Langasek ]
67 * Fix for bug #763148 (with added test cases): when the desktop is
68 resized, windows should stay on their original workspace. (LP:
69 #763148)
70
71 [ Brandon Schaefer ]
72 * Unrevert 3728, fix failing tests. Change the behaviour of
73 undecorating windows. Previously when a window was undecorated, we
74 would shift it back to an appropriate position according to its
75 gravity member. That behaviour was problematic because in the
76 StaticGravity case the window has to just stay in the same place.
77 But then if you had a window with StaticGravity which then did get a
78 decoration and later removed it, it would be placed as though it was
79 decorated and appear to be in the wrong place. The correct behaviour
80 is to place all windows as though they have decorations, and then
81 when decorations are removed, to move the window back to the corner
82 as indicated in its gravity and then expand its size to cover the
83 obscured regions no longer hidden because the decorations went away.
84 (LP: #1165343).   1. Completely remove decorOffsetMove and other
85 related code from      decor.cpp. Put the logic to handle the
86 window->input () - window->border ()      placement offset inside of
87 setWindowFrameExtents instead. Now the window      will always be
88 offset from its original non-decorated position to the new
89      decorated position, rather than having to guess between
90 decoration sizes.   2. Make saveGeometry and restoreGeometry work
91 relative to window->border ()      as opposed to including it in the
92 saved geometry. It is possible that the      border size might
93 change during maximization, as such, we don't want to      save the
94 position with the border before maximizing. Instead save the
95 position      as if it were never decorated so that when the window
96 is restored it can be      restored to its original position and
97 then adjusted for its new border size.   3. Fix a few typoes in the
98 tests.   4. Moved some commonly used matchers into compiz::testing
99   5. Make COMPIZ_PLUGIN_DIR accept multiple directories and look in
100 each one      of them for the plugin   6. Set COMPIZ_PLUGIN_DIR
101 appropriately for each plugin that we wish to load      on startup
102 so that we load locally built plugins as opposed to installed
103      ones.   7. Uncomment compiz_discover_tests for the acceptance
104 tests. Now they are      run by default. (LP: #1195522). (LP:
105 #1195522, #1165343)
106 * If we receive a stateNotifyChange, we check if we are in a max
107 state. If so, overwrite the xwc with either X | W, or Y | H
108 depending on the semi max state with the orig position before we
109 went into a semi max state. This way when we leave any sort of max
110 state the orig position is restored. If the window is being grabbed
111 we do not overwrite the position, which it gets its own value at
112 that point (instead of the orig pos). (LP: #892012)
113
114 [ Marco Trevisan (Treviño) ]
115 * OpenGL Screen: Ignore the MSAA configs during initialization This
116 fixes a crash with new MESA drivers and high monitor resolutions
117 caused by the fact that we're accidentally using some MSAA configs
118 with some drivers in Mesa 9.0. Taking in account the values of
119 GLX_SAMPLES and GLX_SAMPLE_BUFFERS fixes the issue. See mesa bug
120 https://bugs.freedesktop.org/show_bug.cgi?id=61182. (LP: #1174495)
121 * OpenGLES Screen: Ignore the MSAA configs during initialization.
122 * GLScreen: break the iteration as soon as we've found a valid egl
123 config.
124
125 [ Michail Bitzes ]
126 * Plugin wizard ported to OpenGL|ES. Use GLVertexBuffer. Enable
127 building for GLES. Enable architectures armel and armhf. (LP:
128 #1196003). (LP: #1196003)
129
130 [ Chris Townsend ]
131 * Fixed issue where minimizing an unredirect full screen window would
132 repaint the full screen window after minimizing it even though it
133 isn't really there. . (LP: #1053895)
134
135 [ Sami Jaktholm ]
136 * *Grid code: Prevent center and corner gridded windows from jumping
137 viewports. (Thanks and credits for this go to Sami Jaktholm) Prevent
138 top and bottom gridded windows from jumping viewports by making
139 those semi-maximize horizontally. As those are actually semi-
140 maximized horizontally, we will treat them as such and let core
141 handle the restoring, just like we already do for vertically semi-
142 maximized grid windows (left/right). Now "Strg+Super+Down" will
143 restore top and bottom gridded windows correctly as well. Also
144 multiple gridding to top, bottom, left or right will not overwrite
145 the stored original size anymore. Restore windows also when
146 workspace switcher (expo) is active. (Thanks and credits for this go
147 to Sami Jaktholm) Allow cycling for all gridded windows if
148 explicitly specified by the user in CCSM. Forbid cycling through
149 different sizes for corner and center-gridded windows also per
150 default, now fully fixing bug #878820 and following the design
151 specification by Ayatana Design there, making behaviour consistent.
152 Introduced 3 new bools: horzMaximizedGridPosition,
153 vertMaximizedGridPosition, anyMaximizedGridPosition Used these bools
154 inside the if condition checks. Simplified complicated if condition
155 by removing redundant additional size check. Cleanup all around.
156 *Grid xml: Added cycle_sizes bool option, which allows the user to
157 choose the prefered behaviour (fixed versus flexible sizes on
158 multiple presses on the same grid keyboard shortcut). Default of
159 this option is off, cycling disabled as specified by design. Added
160 punctuation where missing and removed it where usually is none.
161 Fixed typos, improved description and titles. *Expo code: Tell grid
162 when viewport change is in progress. (Thanks and credits for this go
163 to Sami Jaktholm) (fixes: LP: #878820, LP: #879218, LP: #882754 and
164 LP: #1082001, partially fixes: #1116538, #1164332). (LP: #882754,
165 #878820, #1164332, #1082001, #879218, #1116538)
166 * Grid: Check that composite and opengl ABIs are COMPIZ_COMPOSITE_ABI
167 and COMPIZ_OPENGL_ABI instead of CORE_ABIVERSION. (LP: #1181461)
168 * Fade: Fix a typo that causes fade to constantly damage windows with
169 a modified saturation. (LP: #1159054)
170 * Grid: Fix window misplacement if a window is restored but the size
171 doesn't change. - Set isGridResized to false before configuring the
172 window in GridScreen::restoreWindow. If the restored geometry is the
173 same as current geometry, configureXWindow will trigger moveNotify
174 instead of resizeNotify. As isGridResized is still true,
175 GridWindow::moveNotify blocks the restoration movement and the
176 pointer detaches from the decoration. - Don't use pointerBufs when
177 calculating position of the restored window with snapback windows
178 disabled. The window will be positioned a bit too high (or low) and
179 the pointer detaches from decoration if the movement was actually
180 tracked. This was a workaround for the first point and can be safely
181 removed. (LP: #1115344)
182 * Fix memory leaks in titleinfo plugin. (LP: #1101569, #1101454)
183 * Expo plugin: 1) Always fetch the dndButton action in dndFini. The
184 action given to dndFini might be a key or edge binding action if
185 expo was terminated during window DnD. We shouldn't set their state
186 to CompAction::StateInitButton or the bindings break. 2) Pass NULL
187 action to termExpo if invoked from handleEvent Previously we passed
188 the action of expoKey to termExpo which in turn passed it to
189 dndFini. DndFini changed the action state to
190 CompAction::StateInitButton that broke the keybinding. Now that
191 dndFini fetches the dndButton action itself, there's no need to
192 fetch it in handleEvent too as dndFini is the only one using the
193 action. (LP: #1131106)
194 * Expo: Cast denominators of integer divisions to floats before
195 performing a matrix translation to viewports with the results.
196 Otherwise rounding errors in cases the results are not an integers
197 cause the viewports to be painted offscreen. (LP: #438580)
198 * Port dbus introspection to compiz 0.9. - move xml creation to a
199 separate class (IntrospectionResponse) for easier memory management
200 (allocate buffer and writer in ctor, free in dtor). - move
201 duplicated response sending code to a separate method that takes
202 IntrospectionResponse and sends the resulting xml. - Refactor
203 handle*IntrospectMessage to work with compiz 0.9 interfaces. This
204 also fixes the broken list method which was a result of logic error.
205 The code to invoke list handler was never reached. This fixes most
206 of the issues noted in bug 749084. (LP: #749084)
207 * Bias the current viewport in addWindowSizeChanges. If window is
208 visible in the current viewport, use that viewport when calculating
209 geometries in addWindowSizeChanges. Otherwise the current method is
210 used. This way visible windows are maximized in the current
211 viewport. However, offscreen windows won't jump back to the active
212 viewport if window maximizes by itself or addWindowSizeChanges is
213 called for some other reason. (LP: #776435)
214 * Expo: Recompute glow quads if a desktop window is resized. (LP:
215 #1090713). (LP: #1090713)
216 * Decor: Use maximized border extents only if window is fully
217 maximized. The decorator draws a normal border around semi-maximized
218 windows. When maximized border extents were used for semi-maximized
219 windows, compiz didn't reserve any space for the border in its
220 geometry calculations. At least following problems are a result of
221 this behavior: - Semi-maximized windows have 1px borders drawn on
222 adjacent workspaces (LP: #986051). - Grid placed window overlaps the
223 adjacent viewport (LP: #898870). (LP: #986051, #898870)
224
225 [ gebner@2b7e.org ]
226 * Adding a uniform to a GLVertexBuffer that uses AutoProgram causes
227 compiz to segfault. Example: gWindow->addShaders("cms", "",
228 fragment_shader); gWindow->vertexBuffer()->addUniform("cms_lut",
229 unit); // segfault happens later in PrivateVertexBuffer::render The
230 patch modifies PrivateVertexBuffer::render to set the uniform on the
231 generated AutoProgram instead of the provided program, which in this
232 case is NULL, causing a segfault. (LP: #1162598). (LP: #1162598)
233
234 [ MC Return ]
235 * Cube-addon (Cube Reflection and Deformation): If the user disables
236 "Draw top face"/"Draw bottom face" we do not want to draw anything
237 (LP: #1162484). The original, non-deformed caps will only work for
238 the non-deformed cube, so we can just use the original function in
239 that case. We need to clear the texture if no texture files are
240 specified in "Image files", otherwise the old texture would still be
241 drawn, even if all image files are removed (LP: #1162711). Now we
242 will default back and use the cube cap colors and opacities defined
243 in the "Desktop Cube" plugin (if "Draw top/bottom face" are enabled
244 only, see above). This way the user can choose between (for
245 top/bottom): 1. Do not draw a cube cap face at all ("Draw top/bottom
246 face" option disabled) 2. Use color and opacity specified in
247 "Desktop Cube" (empty images list) 3. Use a texture for the cap
248 (image is in the list, which is default) Removed redundant mCurrent
249 = mCurrent % mFiles.size (); calculation, this has already been
250 done: cap->mCurrent = (cap->mCurrent + change + count) % count;
251 count and change both need to be != 0 for mCurrent to change. Fixed
252 indentation, removed redundant brackets and newlines, declaration
253 and assignment of local variables in one line, if possible, minor
254 cleanup. (LP: #1162484, LP: #1162711). (LP: #1162484, #1162711)
255 * Stack (Window) Switcher (currently excluded from compilation): Fixed
256 window title drawn although "Show Window Title" is disabled. (LP:
257 #1070782). (LP: #1070782)
258 * *Grid code: Prevent center and corner gridded windows from jumping
259 viewports. (Thanks and credits for this go to Sami Jaktholm) Prevent
260 top and bottom gridded windows from jumping viewports by making
261 those semi-maximize horizontally. As those are actually semi-
262 maximized horizontally, we will treat them as such and let core
263 handle the restoring, just like we already do for vertically semi-
264 maximized grid windows (left/right). Now "Strg+Super+Down" will
265 restore top and bottom gridded windows correctly as well. Also
266 multiple gridding to top, bottom, left or right will not overwrite
267 the stored original size anymore. Restore windows also when
268 workspace switcher (expo) is active. (Thanks and credits for this go
269 to Sami Jaktholm) Allow cycling for all gridded windows if
270 explicitly specified by the user in CCSM. Forbid cycling through
271 different sizes for corner and center-gridded windows also per
272 default, now fully fixing bug #878820 and following the design
273 specification by Ayatana Design there, making behaviour consistent.
274 Introduced 3 new bools: horzMaximizedGridPosition,
275 vertMaximizedGridPosition, anyMaximizedGridPosition Used these bools
276 inside the if condition checks. Simplified complicated if condition
277 by removing redundant additional size check. Cleanup all around.
278 *Grid xml: Added cycle_sizes bool option, which allows the user to
279 choose the prefered behaviour (fixed versus flexible sizes on
280 multiple presses on the same grid keyboard shortcut). Default of
281 this option is off, cycling disabled as specified by design. Added
282 punctuation where missing and removed it where usually is none.
283 Fixed typos, improved description and titles. *Expo code: Tell grid
284 when viewport change is in progress. (Thanks and credits for this go
285 to Sami Jaktholm) (fixes: LP: #878820, LP: #879218, LP: #882754 and
286 LP: #1082001, partially fixes: #1116538, #1164332). (LP: #882754,
287 #878820, #1164332, #1082001, #879218, #1116538)
288 * *Resizeinfo, xml changes: Added option for bold/normal font, default
289 is still bold. Added option to change the font size (10-14), default
290 is still 12 pixel. Enhanced and corrected a few tooltips.
291 *Resizeinfo, code changes: Choose between PANGO_WEIGHT_BOLD and
292 PANGO_WEIGHT_NORMAL. Use individual font size specified by the user
293 in CCSM. Fixed computation of wrong damageRegion, it was
294 additionally adding the window size, making it way too large.
295 Removed useless declaration of int width and height. Declaration and
296 assignment of local variables in one line, if possible. Minor
297 indentation fixes. (LP: #1166195, LP: #1166196 and LP: #1166245).
298 (LP: #1166195, #1166196, #1166245)
299 * *Move xml: Implemented options to configure: "Snapoff Distance"
300 "Snapback Semimaximized Windows" and "Snapback Distance" Improved a
301 few tooltips. *Move code: Replaced SNAP_BACK and SNAP_OFF hardcoded
302 constants and made those configurable. Implemented a strategy to
303 snap off horizontally maximized windows by dragging them along the x
304 axis. Implemented snapping back of horizontally maximized windows
305 and fixed the snapping for vertically maximized windows (wrong
306 cursor calculation). Fixed a few wrong calculations in the if
307 condition checks responsible for snapping off and back. Merged if
308 condition checks. Just compute various local variables if we do not
309 return false. Removed redundant brackets, fixed indentation and
310 improved readability. (LP: #1165198, LP: #1167933). (LP: #1167208,
311 #1167933, #1165198)
312 * Freewins xml: Fixed False->false and True->true typos. Credits and
313 thanks for finding cause and fix go to raveit65 ! (LP: #1163606).
314 (LP: #1163606)
315 * Screenshot code cleanup: Used standard bool for mGrab. Merged a few
316 if condition checks. Declaration and assignment of local variables
317 in one line. Removed redundant brackets. Added and removed newlines
318 to improve readability. Added a missing break (just a style issue).
319 Fixed indentation. C++ style for comments.
320 * *Move xml: Slightly improved long description of the move plugin.
321 Implemented option to change the key move increment size. Removed
322 <precision> settings as they just work for floats. *Move code:
323 Removed hardcoded KEY_MOVE_INC variable. Introduced int
324 moveIncrement to not have to execute optionGetKeyMoveInc () to get
325 the value twice. (LP: #1167933, part 2). (LP: #1167933)
326 * Shift Switcher code cleanup: Merged a few if-if condition checks.
327 Declaration and assignment of local variables in one line. Removed
328 redundant brackets. Added and removed newlines to improve
329 readability. Fixed indentation.
330 * Composite code cleanup: Merged a few if-if condition checks.
331 Declaration and assignment of local variables in one line. Removed
332 redundant brackets. Added and removed newlines to improve
333 readability. Fixed indentation.
334 * *Grid code: Simplified bool GridScreen::restoreWindow (...): If Grid
335 has not touched the window we return false and let core do the dirty
336 work. (Thanks go to Sam Spilsbury for suggesting this solution.)
337 *Grid xml: Improved the CCSM Grid put_restore_key tooltip. (LP:
338 #1116538). (LP: #1116538)
339 * *Cube Gears: Added glDepthMask (GL_TRUE); and glDepthFunc (GL_LESS);
340 to void GearsScreen::cubePaintInside (...) to fix the culling on
341 multimonitor systems (green gear was always rendered in front). Also
342 fixed indentation and removed some redundant newlines. (LP:
343 #1168919). (LP: #1168919)
344 * *Showmouse code cleanup: Assignment and declaration of local
345 variables in one line. Removed redundant brackets. Fixed
346 indentation. Removed and added newlines for better readability.
347 *Showmouse code changes: Removed these redundant gl calls: glEnable
348 (GL_TEXTURE_2D); glDisable (GL_TEXTURE_2D); (partially fixes LP:
349 #1051290 and LP: #1051295). (LP: #1051290, #1051295)
350 * *Workspacenames: New Feature: Implemented option to adjust vertical
351 offset for top and bottom of screen workspacename placement. Set the
352 default offset to 50 pixel. Cleanup: Added brackets to for loop. Use
353 prefix increments. Indentation fixes. Added and removed newlines for
354 better readability. Added comment. Removed TEXT_BORDER constant.
355 Improved tooltips. (LP: #1172063). (LP: #1172063)
356 * *Screenshot, xml: Better plugin summary. Added option to disable the
357 drawing of the screenshot selection indicator. Added options to
358 change color and opacity of the outline and the inside of the
359 rectangle indicator, default colors have not been changed. Other
360 minor improvements. *Screenshot, code: Introduced the new variable
361 bool selectionSizeChanged, which is true if the size of the
362 selection has changed. We just want to draw the screenshot selection
363 box, if we are grabbed, the size has changed and the CCSM option to
364 draw it is enabled. Do not render anything if indicator is disabled.
365 Indicator colors are now configurable. Increased indicator box
366 outline line width to 2.0. Only damage the full screen once, if the
367 grab gets terminated, during grab just damage the region painted,
368 which is the screenshot selection box (LP: #1172234). *SCreenshot,
369 cleanup: Minor cleanup in the rendering code. Removed redundant
370 #ifndef USE_GLES compiler option, GLES can cope with enabling and
371 disabling GL_BLEND. Use prefix- instead of postfix increments.
372 Declaration and assignment of local variables in one line. Reduced
373 the scope of the variables x1, y1, x2 and y2. Replaced magic number
374 65535.0f with const float MaxUShortFloat = std::numeric_limits
375 <unsigned short>::max ();. Indentation fixes. C++ style for
376 comments, added comments. (LP: #1169353, LP: #1172234). (LP:
377 #1169353, #1172234)
378 * Shift Switcher code cleanup: Use prefix instead of postfix increment
379 and decrement. Declaration and assignment of local variables in one
380 line. Merged if statements. Added brackets to for loops. Fixed
381 indentation. Added and removed newlines for better readability.
382 Added comment.
383 * Cube Addon .xml cleanup: Better plugin description. Uppercase
384 titles. Improved tooltips and names.
385 * Animation code cleanup: Use prefix- instead of postfix- in- and
386 decrements. Removed redundant brackets. Added and removed newlines
387 where appropriate. Fixed indentation.
388 * Grid, code cleanup: Merged if statements. Replaced magic number
389 65535.0f with const float MaxUShortFloat = std::numeric_limits
390 <unsigned short>::max ();. Use prefix- instead of postfix-increment.
391 Removed redundant (float) casts. Removed redundant brackets. Added
392 and removed newlines to improve readability. Minor indentation
393 fixes.
394 * Workspacenames .xml cleanup: Better description of the plugin's
395 functionality. Improved tooltips.
396 * Cube .xml cleanup: Better plugin description. Uppercase titles.
397 Improved tooltips.
398 * Shift Switcher .xml cleanup: Better description of the plugin's
399 function. Fixed load before "bs" plugin typo -> it is the obs
400 plugin. Created a "Switcher Mode" tab and moved Flip/Cover mode
401 settings there. Created a subgroup for mouse-specific settings.
402 Better tooltips with enhanced descriptions. Improved titles. Fixes
403 all around (typos, etc.).
404 * Refactor screenshot code to make it clearer and also to allow us to
405 take screenshots in glPaintOutput as opposed to paint (). Taking
406 screenshots in paint () was probably correct pre-GLES, but isn't
407 really correct now - we want to be able to read off of the currently
408 bound scratch framebuffer where we last painted the frame. Reading
409 off the frontbuffer is an imprecise operation because the contents
410 of both buffers are really undefined after a swap. In the case where
411 we are not painting to a scratch framebuffer object, we'll just end
412 up reading from the backbuffer anyways, which would be correct to do
413 mid-frame. Also added the new static const GLenums
414 DRAW_FRAMEBUFFER_BINDING and READ_FRAMEBUFFER_BINDING to opengl.h.
415 (LP: #771875). (LP: #771875)
416 * shift.h: Minor indentation fixes (mostly replaced tabs with spaces).
417 * Show Desktop .xml cleanup: Improved plugin description. Renamed
418 "Misc. Options" tab to "General" Improved tooltips.
419 * Stack Window Switcher (stackswitch): Declaration and assignment of
420 local variables in one line. Merged if condition checks. Use prefix
421 de- and increments. Removed redundant brackets. Fixed indentation.
422 Note: stackswitch is still excluded from compilation, because it has
423 not been ported to the new GLES-compatible modern post-r3320 Compiz
424 codebase yet, so this cannot really be tested at the moment (except
425 in Compiz pre-r3320). Nevertheless this MP is needed to reduce the
426 diff size for the GLES port of this plugin, which will follow soon.
427 * Ring Switcher .xml cleanup: Better description of the "Ring
428 Switcher". Uppercase for titles. More precise names for the tabs.
429 Improved tooltip wording and descriptions. Changed the order of
430 options in "General Options" tab: "Ring Windows" and "Overlay Icon"
431 options are now on top. No settings have been changed.
432 * *Shift Window Switcher, new features: Implemented new option to
433 adjust the vertical offset of the text placement and fixed vertical
434 placement calculation for top and bottom positions. The default
435 offset is 50 pixels now. Removed hardcoded and redundant float
436 border. Use 256x256 pixels resolution for icon textures, instead of
437 96x96. Minor indentation fixes. (LP: #1173684). (LP: #1173684)
438 * Opacity, Brightness and Saturation (obs) .xml cleanup: Better plugin
439 description. Improved setting names and tooltips.
440 * Opacity, Brightness and Saturation (obs) code cleanup: Replaced
441 #define MODIFIER_COUNT 3 with const unsigned short MODIFIER_COUNT =
442 3; (the variable MODIFIER_COUNT is needed in obs.h and obs.cpp). Use
443 prefix instead of postfix increment. Merged if condition checks.
444 Declaration and assignment of local variables in one line. Removed
445 redundant brackets. Added and removed newlines if appropriate.
446 Indentation fixes.
447 * Improved and optimized ABI logic checks consistently for all
448 plugins. (LP: #1178228). (LP: #1178228)
449 * *Grid, code changes and fixes: Fixed segfault in Compiz when
450 unchecking "Snap windows back to original size". This option now
451 fully works and will snap back windows to current size, if they are
452 dragged off via mouse. Fixed segfault in Compiz when unchecking
453 "Snapoff Maximized/Semi-maximized Windows" - this option is now
454 removed as this setting is configurable via "Move" plugin already.
455 The snapoff threshold global setting is now configurable instead of
456 hardcoded. Fixed broken cursor y-coordinate calculation. Fixed
457 window placement cursor calculation for non-original-size-restored
458 windows. Make sure grid-maximizing will never overwrite the windows'
459 original size. Removed useless code until someone can convince me
460 that we need it (LP: #1020857). This fixes the weird positioning
461 (50, 50) when restoring mouse-grid-maximized windows via keyboard.
462 Added missing ABI checks of OpenGL and Composite. *Grid, xml changes
463 and fixes: Put Corners/Edges setting into own tab. New tab named
464 "Resize Actions". Removed hardcoded SNAPOFF_THRESHOLD and made it
465 configurable. Improved tooltips. Re-applied the quilt patch to the
466 changed grid.xml.in. Changed the put_restore_key to
467 "Ctrl+Super+Down" to fix restoring of grid-maximized windows for
468 Ubuntu as well. (LP: #1172641) *Grid, minor code cleanup: Removed
469 redundant (int) casts. Improved readability for the if condition
470 checks. Added and removed newlines, if appropriate. Added comments.
471 Indentation fixes. (LP: #745159, LP: #1020857, LP: #1172641). (LP:
472 #1020857, #745159, #1172641)
473 * Resize, minor code cleanup: Declaration and assignment of local
474 variables in one line. Added and removed newlines, if appropriate.
475 Removed redundant brackets. Indentation fixes.
476 * Wobbly Windows, code cleanup: Declaration and assignment of local
477 variables in one line. Merged if statements. Removed redundant
478 brackets. Added missing break. Removed and added newlines for better
479 readability. Fixed indentation.
480 * Ring, Shift and Stack Window Switcher: Increased the non-power-of-2
481 icon texture resolution from 96x96 to 512x512 pixels, in the case of
482 the ring switcher from 64 to 512. Static Switcher: Replaced #define
483 of MAX_ICON_SIZE with type-safe extern const unsigned short and set
484 the icon resolution to 512 as well. Compiztoolbox: Increased the
485 non-power-of-2 icon texture resolution const unsigned short
486 ICON_SIZE from 48 to 512 and const unsigned int MAX_ICON_SIZE from
487 256 to 512 as well. Changed the type of MAX_ICON_SIZE from const
488 unsigned int to const unsigned short. Scale: Increased the non-
489 power-of-2 icon texture resolution from 96x96 to 512x512 pixels. KDE
490 Compatibility: Increased the icon texture resolution from 256x256 to
491 512x512 pixels. (LP: #1173914). (LP: #1173914)
492 * Removed redundant Expo configuration changes from ubuntu-
493 config.patch: The reflection scale change, because reflection is
494 disabled by default anyway. The inactive viewport saturation change
495 from 100.0% to 40.0%, because this option does not work (and never
496 did AFAICR), but if it finally gets fixed Expo's look would
497 dramatically change. (LP: #1178965). (LP: #1178965)
498 * Expo plugin: Fixed inactive viewports saturation setting being
499 ignored. Let's "fade to grey"... :) (LP: #1179183). (LP: #1179183)
500 * compizconfig/*, libdecoration/*: Use prefix instead of postfix de-
501 and increments.
502 * *Ring Switcher, new feature: Implemented "Vertical Offset" option
503 with a default of 50 pixels. This allows the CCSM user to easily and
504 exactly configure where the window title text should be displayed.
505 Ring Switcher, cleanup: Simplified
506 RingWindow::compareRingWindowDepth (...). Bail out of functions
507 ASAP, do not initialize anything you do not need, if you exit
508 anyway. Merged if condition checks. Declaration and assignment of
509 local variables in one line. Removed redundant brackets. Added and
510 removed newlines, if appropriate. Fixed indentation. (LP: #1173684).
511 (LP: #1173684)
512 * gtk/*, include/*, kde/*: Use prefix instead of postfix de- and
513 increments.
514 * Scale Addons code cleanup: Always bail out of functions ASAP, do not
515 calculate unnecessary stuff before. Merged if-condition checks.
516 Declaration and assignment of local variables in one line. Reduced
517 the scope of some variables. Use pre- instead of postfix in- and
518 decrements. Added and removed newlines where appropriate. Added
519 brackets to foreach macro loops and removed them otherwise (if
520 redundant). Fixed indentation. Note: This plugin has a huge chunk of
521 code, which has been commented out. (apparantly/according to the
522 comment, because it does not work) I was very cautious in
523 refactoring this part of the code, as it currently is excluded from
524 compilation and thus cannot be tested. TODO: Test, repair and
525 integrate this code (or remove it if it is redundant). TODO: Fix
526 half-broken "Exit Scale On Pull". TODO: Fix the scale-will-only-
527 terminate-if-initiate_key-is-defined bug.
528 * *EZoom (Enhanced Zoom Desktop) code cleanup: Optimized ABI check.
529 Use prefix- instead of postfix-increment. Assignment and declaration
530 of local variables in one line. Merged if statements. Removed
531 redundant brackets. Fixed indentation. Added and removed newlines to
532 improve readability. *EZoom (Enhanced Zoom Desktop) code changes:
533 Replaced #define WIDTH (x2 - x1) with int width = x2 - x1; and
534 #define HEIGHT (y2 - y1) with int height = y2 - y1; Replaced WIDTHOK
535 and HEIGHTOK macros with local variables: WIDTHOK and HEIGHTOK just
536 need to be calculated once and can then be used for all cases in
537 void EZoomScreen::ensureVisibilityArea (...). static_cast <float>
538 for int denominators in divisions. Removed these redundant gl calls:
539 glEnable (GL_TEXTURE_2D); glDisable (GL_TEXTURE_2D); Zoom Box fixes:
540 Enabled GL_BLEND for the zoom box to fix transparency issues. Made
541 outline and fill color and transparency of the zoom box
542 configurable. Outline width is 2.0 for the zoom box as well now.
543 (same like for grid preview and screenshot selector outlines) Fixed
544 zoom box damage handling. Minor restructuring in zoom box rendering
545 code. Minor ezoom.xml.in cleanup and enhancements. Load after
546 mousepoll. (fixes LP: #1171665, partially fixes LP: #1051290 and LP:
547 #1051295). (LP: #1171665, #1051290, #1051295)
548 * Wall: Fixed broken wall edge flipping functions: "Edge Flip Pointer"
549 "Edge Flip Move" Removed void WallScreen::updateScreenEdgeRegions ()
550 completely. This function not needed hereat all, no other plugin
551 needs to re-define the screen edge regions by itself - just core
552 should do that. The screen edge region updating also confused the
553 edge flipping functionality. case ConfigureNotify: just breaks out
554 now Added missing default: case and a break (just a style issue).
555 Minor cleanup in bool WallScreen::initiateFlip (...). One
556 declaration per line. Note: "Edge Flip DnD" still seems to be
557 broken, but will be fixed in a follow-up proposal. (LP: #771448, LP:
558 #858845). (LP: #771448, #858845)
559 * Wallpaper .xml.in cleanup: Better plugin description. Improved
560 option names. Better wording of tooltips. Removed redundant
561 newlines. Wallpaper code cleanup: Use prefix instead of postfix
562 increments. Declaration and assignment of variables in one line.
563 Added some newlines to improve readability. Removed redundant
564 brackets. Fixed indentation.
565 * EZoom plugin, code improvements: Bail out of functions ASAP, do not
566 calculate stuff you might not need. Replaced: if (zoom_level == 1.0f
567 && zooms.at (out).newZoom == 1.0f) with: if (zoom_level == zooms.at
568 (out).newZoom) because we always want to get out of here if the
569 target level is the same as current zoom level, not only in the case
570 both are 1.0f. EZoom plugin, code cleanup: Assignment and
571 declaration of variables in one line, if possible. Added and removed
572 some newlines. Merged if condition checks. Indentation fixes.
573 * Mousepoll code cleanup: Removed the unused variables
574 MP_OPTION_MOUSE_POLL_INTERVAL and MP_OPTION_NUM. Declaration and
575 assignment of variables in one line. Added and removed newlines.
576 Removed redundant brackets. Fixed indentation.
577 * Annotate plugin, code cleanup: Use prefix instead of postfix
578 increment. Declaration and assignment of local variables in one
579 line. Removed redundant brackets. Added and removed newlines if
580 appropriate. Fixed indentation. Annotate plugin, fixes: Use
581 GL_LINE_LOOP to draw the rectangle outline as glRecti is not
582 supported on GLES. Simplified the coordinate calculation as the
583 offset is not really needed here.
584 * Titleinfo, minor code cleanup: Declaration and assignment of local
585 variables in one line. Removed redundant brackets. Added and removed
586 newlines. Fixed indentation.
587 * Text plugin code cleanup: Do not declare variables you do not need
588 if you return anyway. Use prefix instead of postfix increments.
589 Merged if condition checks. Declaration and assignment of variables
590 in one line. Added and removed newlines. Removed redundant brackets.
591 Fixed indentation.
592 * ccp code cleanup: Declare variables if you need them, do not declare
593 them if you return. Declare CCSSettingValue *val; outside the
594 foreach loop. Use prefix instead of postfix increments. Merged if
595 condition checks. Declaration and assignment of variables in one
596 line. Removed redundant brackets. Added and removed newlines. Fixed
597 indentation.
598 * Commands, minor code cleanup: Declaration and assignment of
599 variables in one line. Return ASAP. Added and removed newlines.
600 Fixed indentation.
601 * Cube code cleanup: Replaced 0xffff with GLfloat MaxUShortFloat =
602 static_cast <GLfloat> (std::numeric_limits <unsigned short>::max
603 ());. Use prefix instead of postfix de- and increments. Declaration
604 and assignment of variables in one line. Declare variables shortly
605 before you need them. Merged if condition checks. Added missing
606 breaks (just a style issue). Added and removed brackets. Added and
607 removed newlines. Fixed indentation.
608 * action.cpp and actions.cpp code cleanup: Use pre- instead of postfix
609 increment. Declaration and assignment of variables in one line.
610 Merged if condition checks. Removed redundant brackets. Added and
611 removed newlines. Fixed indentation.
612 * Rotate Cube code cleanup: Simplified a few calculations of this
613 type: (360.0 / (x * 2.0)) == 180 / x Declaration and assignment of
614 variables in one line. Use pre- instead of postfix de- and
615 increments. Merged if condition checks. Added and removed newlines
616 and brackets. Fixed indentation. Added TODO comments.
617 * Fade plugin, minor code cleanup: Declaration and assignment of local
618 variables in one line. Merged if condition checks. Use pre- instead
619 of postfix de- and increments. Removed redundant brackets. Added and
620 removed newlines. Fixed indentation.
621 * Opacify code cleanup: Declaration of local variables outside of
622 loops. Calculate activeOpacity and targetOpacity just once, not for
623 each window. Use prefix instead of postfix increments. Merged if
624 condition checks. Declaration and assignment of local variables in
625 one line. Added and removed newlines. Removed redundant brackets.
626 Fixed indentation. Opacify, functionality fix: Improved the toggling
627 logic by setting isToggle in the constructor according to the
628 startup setting, then calling setFunctions (isToggle);,which then
629 calls screen->handleEventSetEnabled (os, os->isToggle); to fix
630 Opacify ignoring the "Toggle Opacify on by default" setting. (LP:
631 #787814). (LP: #787814)
632 * Widget, minor code cleanup: Declaration and assignment of local
633 variables in one line. Merged if condition checks. Added and removed
634 newlines. Added default case to switch (just a style issue). Removed
635 redundant brackets. Fixed indentation.
636 * window.cpp code cleanup: Declare variables outside of loops. Reduced
637 the scope of variables. Do not assign values to variables if those
638 values are not used. Always bail out of functions ASAP, do not
639 calculate stuff you might not need. Use pre- instead of postfix de-
640 and increments. Declaration and assignment of variables in one line.
641 Merged if condition checks. Added and removed brackets. Added and
642 removed newlines. Fixed indentation. Added TODOs (removal of magic
643 numbers).
644 * Fix for cube.cpp, regression r3720 - Inner sides of cube invisible
645 now. Wrong variable type was accidentially used, cullInv is of type
646 int, not bool. (LP: #1183852). (LP: #1184852, #1183852)
647 * src/output*.cpp cleanup: Return ASAP, do not calculate stuff you do
648 not need. Declaration and assignment of variables in one line.
649 Declare local variables outside of loops. Use prefix instead of
650 postfix increment. Added and removed newlines. Fixed indentation.
651 * Expo, code cleanup: Declaration of local variables outside of loops.
652 Use prefix instead of postfix increments. Declaration and assignment
653 of local variables in one line, if possible. Reduced the scope of
654 some variables. Removed redundant brackets. Used static_cast <>
655 (type) instead of (type) cast. Added and removed newlines if
656 appropriate. Fixed indentation. Added TODOs. Expo, speed
657 improvements: Do not calculate screen->vpSize ().width () and
658 screen->vpSize ().height () multiple times, instead save them in the
659 unsigned ints vpCountHorz and vpCountVert and use those variables
660 instead. Speed up the curve calculations by using additional
661 variables to save results to not have to re-calculate those all the
662 time. The new variables introduced are degToRad, screenWidth,
663 screenWidthSquared, curveDistSquaredPlusQuarter,
664 pOne2MinusCurveDist, v0Squared and v2Squared. Also introduced const
665 float halfGapX = gapX / 2.0 and used this variable in the
666 calculations of curveDistance and curveRadius. Simplified
667 calculations of this type: (M_PI / 180.0f) * curveAngle / 2.0, which
668 is equal to: (M_PI / 360.0f) * curveAngle Do not call
669 optionGetGroundSize (); twice, instead save the value in the float
670 groundSize and use that variable in the following calculations.
671 Removed the creation of the redundant bool hide, which is just used
672 once in an if-condition check. It does not help to have this bool.
673 Try to avoid redundant GL_BLEND state changes, they are expensive -
674 only enable GL_BLEND if it is disabled and just disable it, if it
675 was disabled before, otherwise do nothing. Try to avoid redundant GL
676 filter changes - just query the filter state if the mipmap option in
677 CCSM is enabled. Also just set back the filter to the previous state
678 if we actually changed it, otherwise do nothing. -5.5f * 2 = -11.0f.
679 No need to calculate M_PI / 180.0f 720 times: Calculate this value
680 once instead and save it in the const float mpi, use mpi in the
681 following looped calculations. Use const int scw in the same loop
682 instead of calling screen->width () 360 times. glow.cpp: Massively
683 increased calculation speed of the glow texture: No need for any
684 macros here -> removed them and replaced them with local variables.
685 Precalculate values, store them in local variables and use those in
686 the following calculations (new variables are the ints winRealX,
687 winRealY, winRealWidth, winRealHeight, halfWinRealWidth,
688 halfWinRealHeight, xPlusHalfWidth, yPlusHalfHeight, xPlusGlowOff,
689 yPlusGlowOff, xMinusGlowOff, yMinusGlowOff and the float glowPart).
690 Used w->geometry ().widthIncBorders () and w->geometry
691 ().heightIncBorders () to determine winRealWidth and winRealHeight.
692 Expo, fixes: Do not force "One wall per output" on the user, if his
693 displays use different resolutions. "One big wall" makes a lot of
694 sense for many multi-screen configs, where not all of the screens
695 have exactly the same resolution, so if the user explicitely chooses
696 this mode, Compiz should respect the user's choice. (LP: #1009592).
697 (LP: #1009592)
698 * Compiz, redundant and outdated files cleanup: Removed outdated NEWS
699 files. Removed outdated AUTHORS and ChangeLog files. Removed
700 plugins/freewins/COPYING - we do not need another copy of the GPL v2
701 here. Removed another copy of the GPL v2 from plugins/workarounds.
702 This will reduce package sizes, download time and bring some order
703 to chaos.
704 * Expo, .xml.in fixes: Better description of the plugin. Improved and
705 fixed tooltips. Moved the "Curve Strength" option closer to
706 "Deformation". Refreshed the quilt patch for Ubuntu: There is no
707 need to set the default distance to 0.005 as this setting has no
708 effect without deformation. Set default multi-screen mode to "One
709 wall per output" for Ubuntu, because "One big wall" works now for
710 all display configurations and could potentially change the
711 appearance for Ubuntu users. (LP: #1074487). (LP: #1074487)
712 * Added contribute directory. Added QtCreatorConfig.xml, a
713 configuration file for Qt Creator, which adjusts Qt Creator's C++
714 indentation style to be the same that is used in the Compiz project
715 (X11, mixed spaces and tabs).
716 * Mousepoll: Fixed mousepoll version mismatch. (COMPIZ_MOUSEPOLL_ABI
717 was missing) (LP: #1195659). (LP: #1195659)
718 * Expo: Simplified the GL filter handling.
719 * Fixed broken text in all plugins (missing COMPIZ_TEXT_ABI). (LP:
720 #1196493). (LP: #1196493)
721 * CCSM: Fixed vertical alignment of the text on the stylized keys.
722 (Shift, Super, Ctrl, Alt) (LP: #1196345). (LP: #1196345)
723 * Thumbnail, cleanup: Merged if condition checks. Declaration of
724 variables when they are needed (C++ style). Removed redundant
725 brackets. Removed useless "/* Could someone please explain how this
726 works */" comment. Removed extern const unsigned short
727 TEXT_DISTANCE, because this variable does not exist anymore (value
728 is configurable already). Changed if (something > 0.0) to if
729 (something), 10 times. Changed pointedWin = 0; to pointedWin =
730 NULL;. Used centerX () and centerY () abstractions from
731 compiz::window::Geometry to determine the icon center coordinates.
732 Added and removed newlines, if appropriate. Fixed indentation.
733 Thumbnail, code speedup: Return ASAP, do not calculate stuff you
734 might not need. No need for WIN_W (w) and WIN_H (w) macros, removed
735 those and replaced them with the local variables int winWidth, int
736 winHeight, int dockWidth and int dockHeight. No need for WIN_X (w)
737 and WIN_Y (w) macros, replaced those with int dockX and int dockY.
738 Introduced int tHeight = thumb.height;, int tWidth = thumb.width;,
739 int halfTWidth = tWidth / 2; and int halfTHeight = tHeight / 2; and
740 used those variables in the following calculations. Use
741 igMidPoint[0] and igMidPoint[1] as arguments in the screen-
742 >outputDeviceForPoint (arg1, arg2) function, instead of re-
743 calculating the arguments again. Thumbnail, GL speedup: Introduced
744 GLfloat wxPlusWidth = wx + width;, GLfloat wyPlusHeight = wy +
745 height;, GLfloat wxPlusWPlusOff = wxPlusWidth + off;, GLfloat
746 wyPlusHPlusOff = wyPlusHeight + off;, GLfloat wxMinusOff = wx - off;
747 and GLfloat wyMinusOff = wy - off; and used those coordinates in the
748 vertexData arrays. No need to re- calculate those values multiple
749 times. Just query optionGetShowDelay () once and use int showDelay
750 later. We just enable blending if it is currently disabled and
751 disable blending only, if it was disabled before.
752 * src/session.cpp cleanup: Declaration and assignment of local
753 variables in one line. (this *should* fix bug #1101405) Use pre-
754 instead of postfix increments. Added and removed newlines. Added
755 missing break (just a style issue). Fixed indentation. (LP:
756 #1101405). (LP: #1101405)
757 * Firepaint, code cleanup: Declare variables outside of loops.
758 Declaration and assignment of local variables in one line. Use pre-
759 instead of postfix increment. Removed redundant newlines. Removed
760 redundant casts. (from (float) optionGetFireColor) Removed redundant
761 brackets. Added missing break (style issue only). Added comment and
762 TODO. Fixed indentation. Firepaint, speedup: We just enable GL_BLEND
763 if it is disabled and we just disable GL_BLEND if it was disabled
764 before. Introduced the GLfloats xMinusW, xPlusW, yMinusH and yPlusH
765 to store calculated coordinates instead of recalculating them
766 multiple times. Introduced float fireLife = optionGetFireLife ();,
767 float fireWidth = optionGetFireSize ();, float fireHeight =
768 fireWidth * 1.5f; and bool mystFire = optionGetFireMystical (); and
769 used those variables inside the loop. Firepaint, .xml.in cleanup:
770 Firepaint now has 2 tabs, 'General' and 'Particle Settings'. The
771 name of this plugin is Firepaint, <short> should not contain the
772 description. Better description of the plugin. Uppercase option
773 titles. Punctuation for tooltips. Improved tooltips. Firepaint,
774 fixes: Initialize all class member variables in the ParticleSystem::
775 ParticleSystem () ctor (LP: #1101512, LP: #1101580). (LP: #1101512,
776 #1101580)
777 * img* plugins code cleanup: Always bail out of function ASAP, do not
778 calculate stuff you might not need. Declare variables outside of
779 loops so they won't be re-declared in each loop. Use prefix instead
780 of postfix increments. Declaration and assignment of variables in
781 one line. Merged if condition checks. Added and removed brackets.
782 Added and removed newlines, if appropriate. Minor code structure
783 improvements, declare variables when you need them, not much
784 earlier. Fixed indentation.
785 * Text, speed improvements: Introduced const float halfPi = PI / 2.0f;
786 and const float triHalfPi = halfPi * 3; and used those to draw the
787 rounded background. Introduced GLfloat xPlusWidth = x + width; and
788 GLfloat yMinusHeight = y - height; and used those coordinates for
789 the vertexData array. Text, cleanup: Declaration of local variables
790 outside of loops. Fixed indentation.
791 * cube.cpp, code cleanup: #include "privates.h", not <privates.h>.
792 Merged if condition checks. Declaration of variables, where you need
793 them to improve the code structure and readability. Use C++ standard
794 bool for topDir, bottomDir, allCaps and mCapsPainted[output] (bool
795 true/false instead Bool TRUE/FALSE). Initialize all of the class
796 member variables in the constructor. Replaced if (priv->mSky.size ()
797 > 0) with if (!priv->mSky.empty ()). Removed redundant brackets.
798 Fixed indentation. Added TODO. cube.cpp, code speedup: Do not call
799 optionGetInactiveOpacity () twice, instead save the value as float
800 inactiveOpacity and use this variable in the following calculation.
801 Introduced the variables float halfHsize = hsize / 2.0; and float
802 tsSize = 360.0f / size; and used those in following calculations to
803 not have to recalculate those values multiple times. Do not
804 calculate M_PI / sides and 2 * M_PI / sides multiple times in loops,
805 instead save those values in the GLfloats mps and tmps and use those
806 values inside the loops. Use GLdouble mDist2 = 0.5 / mDistance; in
807 the GLdouble clipPlane* arrays, instead of recalculating this value
808 multiple times. Use GLfloat oneMinusFStepX = 1.0f - fStepX; and
809 GLfloat oneMinusFStepY = 1.0f - fStepY; instead of calculating those
810 values multiple times. Use float outputWidth = outputPtr->width ();
811 and float outputHeight = outputPtr->height (); instead of calling
812 the functions multiple times. Introduced the GLfloat normInvert =
813 0.5f * invert; and used this variable instead of recalculating this
814 value multiple times. Introduced the GLfloats mSkyWidth and
815 mSkyHeight and used those in the following loops instead of calling
816 mSkySize.width () and mSkySize.height () multiple times. Try to
817 avoid redundant GL_BLEND state changes, because OpenGL will blindly
818 change the global state, no matter what it currently is set to and
819 that state change is expensive. So we query and save the actual
820 blending state in the variable GLboolean glBlendEnabled =
821 glIsEnabled (GL_BLEND); and just enable it if it isn't already and
822 just disable it, if it was disabled before. (LP: #1101422, LP:
823 #1195977) cube.cpp, other fixes: Return false in function
824 PrivateCubeScreen::updateGeometry (int, int) if sides should ever be
825 0, which should never happen, but should make Coverity happy. (LP:
826 #1101541) Initialize all class member variables in the
827 PrivateCubeScreen:: PrivateCubeScreen (CompScreen *) constructor.
828 (mTc, mNOutput, mOutput, mOutputMask, mCleared, mCapsPainted) (LP:
829 #1101575). (LP: #1195977, #1101541, #1101422, #1101575)
830 * plugins/ezoom/src/ezoom.cpp: Also initialize xtrans and ytrans in
831 the ctors. Just just enable blending if it is disabled and just
832 disable it if it was disabled before. Introduced the variables
833 oWidth, oHeight, halfOWidth and halfOHeight to speed up following
834 calculations. Return ASAP, do not calculate possibly redundant
835 stuff. Declaration and assignment of local variables in one line.
836 Improved readability. Added and removed newlines. Minor indentation
837 fixes. plugins/ezoom/ezoom.xml.in: Removed redundant whitespaces
838 from a tooltip. (LP: #1101572). (LP: #1101572)
839
840 [ Hu Kang stevenhooke11@gmail.com ]
841 * workarounds.cpp: Fix typo in call to XShapeSelectInput. (LP:
842 #1167284). (LP: #1167284)
843 * Use XIDefineCursor rather than XDefineCursor. compiz should show a
844 busy cursor during the application startup stage. the corresponding
845 code is in scr/screen.cpp:
846 cps::StartupSequenceImpl::updateStateFeedback () the patch changes
847 all XDefineCursor to XIDefineCursor (see XInput2 extension) (LP:
848 #1179155). (LP: #1179155)
849
850 [ Łukasz 'sil2100' Zemczak ]
851 * Qt is stupid since it uses the stupid X11 protocol - let's not set
852 all the attributes (especially override_redirect) every time, only
853 in cases when it's actually needed (LP: #1141079). (LP: #1141079)
854
855 [ Andrea Azzarone ]
856 * Satisfy matchers on getProperty as soon as they are set. The order
857 of evaluation for matchers in Google Mock appears to be undefined -
858 this means that we can't rely on the first argument being matched
859 first and the second argument being matched afterwards. In turn,
860 this means that any GValue may be passed to a GValueMatch which, by
861 a design flaw, is unable to handle any values of a type it does not
862 expect (at least not without an API change). It will silently pass
863 the incorrect type to g_type_get_* which causes internal assertion
864 failures. At the moment we're just interleaving the calls to
865 getProperty and get_property - that way the expectations are
866 satisfied and go away as soon as they're set. This in turn means
867 that Google Mock only has to traverse one matcher rather than
868 multiple matchers. (LP: #1187468). (LP: #1187468)
869 * Extends invisible borders to the title bar too. (LP: #717444). (LP:
870 #717444)
871 * Disable grid/put_maximize_key on ubuntu.
872 * Port to new gmock. Disable some faling tests because of weird leaks.
873 (LP: #1185265)
874 * Update window geo only on new decoration size only if mapped. (LP:
875 #1198000). (LP: #1198000)
876 * Disable show_desktop_key by default on ubuntu. Will provide the same
877 option under the unityshell panel. (LP: #1204664)
878 * Use Glib::RefPtr<Glib::Source> in glib_integration_test and compiz
879 core too. After the fix of bug
880 https://bugzilla.gnome.org/show_bug.cgi?id=561885
881 Glib::Source::~Source is called when both Source::unreference() and
882 SourceCallbackData::destroy_notify_callback() are called. (LP:
883 #1214459)
884
885 [ Sam Spilsbury ]
886 * Also take into account the gravity requirements when validating
887 reposition requests. Get most of that code under test too. (LP:
888 #1159324). (LP: #1159324)
889 * Install compizconfig backends to the correct libdir (LP: #1163611).
890 (LP: #1163611)
891 * Don't timeout after 3000ms when asking compiz for a startup message.
892 It can sometimes take longer in the valgrind case. Also timeouts are
893 bad design for tests. (LP: #1169170). (LP: #1169170)
894 * Check for USE_GCONF if USE_GSETTINGS is unavailable when
895 instantiating different types of settings objects. (LP: #1169172).
896 (LP: #1169172)
897 * Link in CMAKE_THREAD_LIBS_INIT through GTEST_BOTH_LIBRARIES so it
898 gets included in everything. Remove redundant links. Require
899 FindThreads.cmake. (LP: #1171364). (LP: #1171364)
900 * Explicitly check if the smart pointers are null rather than
901 converting implicitly to bool as boost 1.53 now marks the bool
902 operator as explicit (LP: #1172601). (LP: #1172601)
903 * Rewrite screen size change tests. 1. Rename the overly-terse
904 variables names to variables names that have some significance 2.
905 Split the giant three-test structure into multiple tests each with
906 only one assert 3. Remove a lot of redundant calculation 4. Remove
907 magic numbers peppered throughout the code. Use constants and
908 express asserts as relationships between those constants. 5.
909 Refactor some of the more common test-advancement code (such as
910 changing the screen size) into the test fixture as common methods.
911 (LP: #1167983). (LP: #1167983)
912 * Refactor screenshot code to make it clearer and also to allow us to
913 take screenshots in glPaintOutput as opposed to paint (). Taking
914 screenshots in paint () was probably correct pre-GLES, but isn't
915 really correct now - we want to be able to read off of the currently
916 bound scratch framebuffer where we last painted the frame. Reading
917 off the frontbuffer is an imprecise operation because the contents
918 of both buffers are really undefined after a swap. In the case where
919 we are not painting to a scratch framebuffer object, we'll just end
920 up reading from the backbuffer anyways, which would be correct to do
921 mid-frame. Also added the new static const GLenums
922 DRAW_FRAMEBUFFER_BINDING and READ_FRAMEBUFFER_BINDING to opengl.h.
923 (LP: #771875). (LP: #771875)
924 * Set libcompizconfig_libdir before the modules get a chance to see
925 it. (LP: #1173799). (LP: #1173799)
926 * Try to launch tests on another server if there's tests running in
927 parallel. Provide our own compiz_xorg_gtest_main and subclass
928 xorg::testing::Environment to try and launch tests on another
929 display if there's tests running on one already. This isn't by any
930 means perfect - there are still race conditions surrounding
931 XOpenDisplay and parallel test runs but it makes a more smaller time
932 gap for conditions such as:  1. Client has a server grab on the
933 display we're checking     and won't let go.  2. Two servers get
934 launched on one port and one set of tests     interfere with the
935 other. It also means that we're now unable to configure the display
936 port, log file and config file on the command line. But we weren't
937 using that anyways. Finally, the logs now point to
938 /tmp/Compiz.Xorg.GTest.displaynum.log (LP: #1178514). (LP: #1178514)
939 * Fix some files not installing: 1. gsettings schemas never get added
940 to the install_manifest list because we use install (CODE) so we
941 need to add a custom uninstall target for those, and also need to
942 recompile on uninstall too 2. Run the gtk-update-icon-cache stage
943 during install for ccsm and also add icon-theme.cache to the
944 uninstall target (LP: #1168475). (LP: #1168475)
945 * Wall: Fixed broken wall edge flipping functions: "Edge Flip Pointer"
946 "Edge Flip Move" Removed void WallScreen::updateScreenEdgeRegions ()
947 completely. This function not needed hereat all, no other plugin
948 needs to re-define the screen edge regions by itself - just core
949 should do that. The screen edge region updating also confused the
950 edge flipping functionality. case ConfigureNotify: just breaks out
951 now Added missing default: case and a break (just a style issue).
952 Minor cleanup in bool WallScreen::initiateFlip (...). One
953 declaration per line. Note: "Edge Flip DnD" still seems to be
954 broken, but will be fixed in a follow-up proposal. (LP: #771448, LP:
955 #858845). (LP: #771448, #858845)
956 * Add a small compiz_autopilot_acceptance_tests binary based on gtest.
957 This will find autopilot and run a predefined list of tests, wrapped
958 up in the familiar google test format. The predefined list is
959 basically a bunch of tests which effectively interact with the
960 window manager. (LP: #1170013). (LP: #1170013)
961 * Change the behaviour of undecorating windows. Previously when a
962 window was undecorated, we would shift it back to an appropriate
963 position according to its gravity member. That behaviour was
964 problematic because in the StaticGravity case the window has to just
965 stay in the same place. But then if you had a window with
966 StaticGravity which then did get a decoration and later removed it,
967 it would be placed as though it was decorated and appear to be in
968 the wrong place. The correct behaviour is to place all windows as
969 though they have decorations, and then when decorations are removed,
970 to move the window back to the corner as indicated in its gravity
971 and then expand its size to cover the obscured regions no longer
972 hidden because the decorations went away. (LP: #1165343). (LP:
973 #1165343)
974 * Added some new hooks to PluginClassHandler to allow a VTable to
975 specify if loaded. PluginClassHandler::get () was designed to simply
976 instantiate an instance of that class for the core structure, but it
977 did this without checking if the plugin was loaded. Added some new
978 methods to PluginClassHandler exposed by LoadedPluginClassBridge and
979 only accessible by those who implement PluginKey to specify globally
980 whether or not a plugin is actually loaded, so that
981 PluginClassHandler can return accordingly. Integration and unit
982 tests added as appropriate (LP: #1169620) (LP: #1101026). (LP:
983 #1101026, #1169620)
984 * Satisfy matchers on getProperty as soon as they are set. The order
985 of evaluation for matchers in Google Mock appears to be undefined -
986 this means that we can't rely on the first argument being matched
987 first and the second argument being matched afterwards. In turn,
988 this means that any GValue may be passed to a GValueMatch which, by
989 a design flaw, is unable to handle any values of a type it does not
990 expect (at least not without an API change). It will silently pass
991 the incorrect type to g_type_get_* which causes internal assertion
992 failures. At the moment we're just interleaving the calls to
993 getProperty and get_property - that way the expectations are
994 satisfied and go away as soon as they're set. This in turn means
995 that Google Mock only has to traverse one matcher rather than
996 multiple matchers. (LP: #1187468). (LP: #1187468)
997 * Revert revision 3278.
998 * Immediately update the window matrices and regions if the number of
999 textures changed. (LP: #1189369). (LP: #1189369)
1000 * Provide a basic decor plugin acceptance test suite. This change
1001 provides a simple acceptance test suite for the decor plugin. It
1002 creates a fake window decorator (cdt::FakeDecorator) and allows
1003 users to create fake decorations (eg cdt::FakePixmapDecoration)
1004 which can be serialized as decoration properties and set on windows
1005 under xorg-gtest. It also launches compiz with the opengl, composite
1006 and decor plugins loaded and runs some basic tests. Among them:
1007 BaseDecorAcceptance. Startup: Basic canary "can we start compiz with
1008 these plugins" test
1009 FakeDecoratorSessionOwnerNameSetOnSelectionOwner: Create a fake
1010 decorator, ensure that libdecoration sets our session name "fake" on
1011 the selection owner FakeDecoratorReceiveClientMessage: Create fake
1012 decorator, ensure that libdecoration posts a client message to the
1013 root window announcing that the new decorator exists.
1014 DecorationSupportsWindowType: Create a fake decorator, announce
1015 support for the WINDOW type decorations and ensure that the correct
1016 atom is set on the session owner window.
1017 DecorationSupportsPixmapType: Create a fake decorator, announce
1018 support for the PIXMAP type decorations and ensure that the correct
1019 atom is set on the session owner window.
1020 DecorFakeDecoratorAcceptance. WindowDefaultFallbackNoExtents: By
1021 default, newly created windows should recieve a fallback decoration
1022 but they should not have any frame extents.
1023 DecorWithPixmapDefaultsAcceptance. These tests create a default
1024 pixmap decoration to use in the hypothetical situation that the
1025 window decorator hasn't yet generated a decoration for this window.
1026 FallbackRecieveInputFrameNotify: Verify that we get a
1027 _COMPIZ_WINDOW_DECOR_INPUT_FRAME property set on the client when it
1028 is created and mapped (eg, an input frame window was annonuced to be
1029 created) FallbackHasInputFrameInParent: Verify that a second window
1030 exists in the frame window after this message was recieved.
1031 FallbackNormalWindowExtentOnDecoration: Verify that
1032 _NET_FRAME_EXTENTS is set to the default window extents for the
1033 default decoration when the window was mapped.
1034 FallbackNormalWindowInputOnFrame: Verify that the input window
1035 matches the extents set. PixmapDecoratedWindowAcceptance. These
1036 tests create a new window and an associated unique decoration for
1037 that window. MaximizeBorderExtentsOnMaximize: Maximize the window
1038 and ensure that the correct border extents are used.
1039 MaximizeBorderExtentsOnVertMaximize: Vertically maximize the window
1040 and ensure that the correct border extents are used.
1041 MaximizeBorderExtentsOnHorzMaximize: Horizontally maximize the
1042 window and ensure that the correct border extents are used.
1043 MaximizeFrameWindowSizeEqOutputSize: Maximie the window and ensure
1044 that the frame window exactly equals the output size.
1045 VertMaximizeFrameWindowSizeEqOutputYHeight: Maximize the window and
1046 ensure that the frame window's Y and Height values are consistent
1047 with the output size. HorzMaximizeFrameWindowSizeEqOutputXWidth:
1048 Ditto horizontal maximization.
1049 DISABLED_VertMaximizeFrameWindowSizeSameXWidth: Maximize the window
1050 vertically and ensure that the frame window's border-relative X
1051 position and width does not change. This test is disabled, as the
1052 behavior in compiz is currently broken, (but it means that we can
1053 fix it later and enable the test).
1054 DISABLED_HorzMaximizeFrameWindowSizeSameYHeight Maximize the window
1055 horizontally and ensure that the frame window's border-relative Y
1056 position and height does not change. This test is disabled, as the
1057 behavior in compiz is currently broken, (but it means that we can
1058 fix it later and enable the test). (LP: #1188900). (LP: #1188900)
1059 * Only mark for no further instantiations once we've finished
1060 destructing the plugin (LP: #1193596). (LP: #1193596)
1061 * Add more acceptance tests for the decor plugin.
1062 PixmapDecoratedWindowAcceptance. UndecoratedWindowExpandToOrigSize
1063 Test that upon undecoration, the window has exactly the same
1064 geometry as it did before decoration.
1065 DISABLED_UndecorateStaticGravityWindow Tests that for windows with a
1066 static gravity, the window has exactly the same geometry as it did
1067 before decoration. Disabled, as core is currently not moving the
1068 window with the static gravity back to where it started.
1069 AdjustmentExtents/PixmapDecorationAdjustment.
1070 AdjustRestoredWindowBorderMovesClient/P Test that changing the
1071 border extents causes the client window's absolute geometry to
1072 change. DISABLED_AdjustRestoredWindowBorderShrinkClient/P Tests that
1073 changing the border extents causes the client window's absolute
1074 geometry to shrink by the amount of border. Disabled, as the current
1075 behavior is to expand the frame window as opposed to shrinking the
1076 client (but this will be changed).
1077 DISABLED_ClientExpandsAsBorderShrinks/P Tests that as the border
1078 shrinks away, the client expands back to its original size.
1079 Disabled, as the current behavior is to expand the frame window as
1080 opposed to shrinking the client (but this will be changed).
1081 DISABLED_ClientExpandsAsBorderShrinksWhilstMaximized/P Tests that
1082 even if the client is maximized, if the restored border shrinks away
1083 it demaximizes back to the same position while also accounting for
1084 any change in the restored window border size. Disabled, as the
1085 current behavior is to expand the frame window as opposed to
1086 shrinking the client (but this will be changed).
1087 DISABLED_ClientExpandsAsBorderShrinksWhilstUndecorated/P Tests that
1088 even when the client is not permitted to be decorated because the
1089 decoration hint was removed, when it is redecorated it will be moved
1090 to the correct position taking into account any changes in its
1091 border size. Disabled, as the current behavior is to expand the
1092 frame window as opposed to shrinking the client (but this will be
1093 changed). DISABLED_AdjustRestoredWindowInputNoMoveClient/P Tests
1094 that adjusting the input extents (as independent from the border
1095 extents) of the client does not cause the client to move. Disabled,
1096 as this behavior appears to be broken in core. Move the
1097 "GetImmediateParent" function into the compiz::testing namespace so
1098 that it can be used by other tests. (LP: #1188900)
1099 * Unrevert 3728, fix failing tests. Change the behaviour of
1100 undecorating windows. Previously when a window was undecorated, we
1101 would shift it back to an appropriate position according to its
1102 gravity member. That behaviour was problematic because in the
1103 StaticGravity case the window has to just stay in the same place.
1104 But then if you had a window with StaticGravity which then did get a
1105 decoration and later removed it, it would be placed as though it was
1106 decorated and appear to be in the wrong place. The correct behaviour
1107 is to place all windows as though they have decorations, and then
1108 when decorations are removed, to move the window back to the corner
1109 as indicated in its gravity and then expand its size to cover the
1110 obscured regions no longer hidden because the decorations went away.
1111 (LP: #1165343).   1. Completely remove decorOffsetMove and other
1112 related code from      decor.cpp. Put the logic to handle the
1113 window->input () - window->border ()      placement offset inside of
1114 setWindowFrameExtents instead. Now the window      will always be
1115 offset from its original non-decorated position to the new
1116      decorated position, rather than having to guess between
1117 decoration sizes.   2. Make saveGeometry and restoreGeometry work
1118 relative to window->border ()      as opposed to including it in the
1119 saved geometry. It is possible that the      border size might
1120 change during maximization, as such, we don't want to      save the
1121 position with the border before maximizing. Instead save the
1122 position      as if it were never decorated so that when the window
1123 is restored it can be      restored to its original position and
1124 then adjusted for its new border size.   3. Fix a few typoes in the
1125 tests.   4. Moved some commonly used matchers into compiz::testing
1126   5. Make COMPIZ_PLUGIN_DIR accept multiple directories and look in
1127 each one      of them for the plugin   6. Set COMPIZ_PLUGIN_DIR
1128 appropriately for each plugin that we wish to load      on startup
1129 so that we load locally built plugins as opposed to installed
1130      ones.   7. Uncomment compiz_discover_tests for the acceptance
1131 tests. Now they are      run by default. (LP: #1195522). (LP:
1132 #1195522, #1165343)
1133 * Add a simple script for making releases.
1134 * Port to new gmock. Disable some faling tests because of weird leaks.
1135 (LP: #1185265)
1136 * Don't add the frame to the toplevel stack if it hasn't been created
1137 yet. In the event that a window is unreparented or destroyed, we
1138 usually need to add its frame window to the toplevel window stack
1139 until the time at which we recieve a DestroyNotify for it, as there
1140 may be incoming ConfigureNotify events puporting to stack other
1141 windows relative to that frame. However, this does not apply in the
1142 case where we have not yet received a CreateNotify for the frame
1143 window. In that case, it is not possible for any stacking requests
1144 to be made relative to this window, so it does not need to be added
1145 immediately. Instead, we can add it at the time that we recieve a
1146 CreateNotify for it as a regular override redirect window until the
1147 time that it is later destroyed. (LP: #1171314). (LP: #1171314)
1148 * Remove redundant src/logmessage/include/core/logmessage.h (LP:
1149 #1067246). (LP: #1067246)
1150 * Adjust acceptance tests for the fix to LP: #1198000 1. Always set
1151 frame extents before updating the frame 2. Added
1152 COMPIZ_NO_CONFIGURE_BUFFER_LOCKS so that we don't have to deal with
1153 the delayed configure requests logic in the tests where it does not
1154 help 3. Split restoredDecorationSize in to
1155 restoredDecorationBorderSize and restoredDecorationInputSize so that
1156 we can measure the size of the decoration both in terms of its
1157 visible and invisible border 4. Wait for the default decoration
1158 properly 5. Capture the initial geometry of the window with and
1159 without decorations when the window gets its first decoration. Use
1160 these values to calculate the size changes in the window from then
1161 on instead of its creation values 6. Just flag when the window was
1162 first decorated in setWindowFrameExtents rather than checking if it
1163 is mapped. We only want to not resize the window once. (LP:
1164 #1198000)
1165 * Release version 0.9.10.0
1166 * Bump VERSION to 0.9.10.2
1167
1168 [ Ubuntu daily release ]
1169 * Automatic snapshot from revision 3781
1170
1171 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 22 Aug 2013 06:58:07 +0000
1172
1173compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu4) saucy; urgency=low
1174
1175 * Remove debian/patches/unity_support_test.patch
1176 - Running the support test from compiz has bad side effects, so we no
1177 longer require this patch (also LP: #1066764)
1178
1179 -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Mon, 12 Aug 2013 13:11:18 +0200
1180
1181compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu3) saucy; urgency=low
1182
1183 * No change rebuild to drop the buggy libhybris depends
1184
1185 -- Sebastien Bacher <seb128@ubuntu.com> Thu, 08 Aug 2013 10:50:09 +0200
1186
1187compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu2) saucy; urgency=low
1188
1189 * Fixing FTBFS in saucy:
1190 - Cherry pick boost1.53 fixes from upstream branch.
1191 - Do not enable -Wno-unused-private-field.
1192
1193 -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Mon, 01 Jul 2013 20:56:50 +0100
1194
1195compiz (1:0.9.9~daily13.04.18.1~13.04-0ubuntu1) raring; urgency=low
1196
1197 [ Ken VanDine ]
1198 * Revert 3636 from lp:compiz/0.9.9 to fix Qt apps getting window decorations
1199 placed behind the panel. (LP: #1165343)
1200 - This reintroduces bug 1159324, Guake window appears placed by offset
1201 non-existent decoration
1202 * [regression-r3635] Guake window appears placed by offset non-
1203 existent decoration (LP: #1159324)
1204
1205 [ Ubuntu daily release ]
1206 * Automatic snapshot from revision 3650
1207
1208 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Thu, 18 Apr 2013 05:46:57 +0000
1209
1210compiz (1:0.9.9~daily13.04.15-0ubuntu1) raring; urgency=low
1211
1212 [ Łukasz 'sil2100' Zemczak ]
1213 * [regression-r3606] Compiz broken with QT menus/floating controls in
1214 13.04 (LP: #1141079)
1215
1216 [ Ubuntu daily release ]
1217 * Automatic snapshot from revision 3648
1218
1219 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Mon, 15 Apr 2013 04:17:27 +0000
1220
1221compiz (1:0.9.9~daily13.04.10-0ubuntu1) raring; urgency=low
1222
1223 [ Steve Langasek ]
1224 * Adding/Removing an external monitor causes open windows to move to
1225 another workspace (LP: #763148)
1226
1227 [ Ubuntu daily release ]
1228 * Automatic snapshot from revision 3646
1229
1230 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 10 Apr 2013 04:03:14 +0000
1231
1232compiz (1:0.9.9~daily13.04.05-0ubuntu1) raring; urgency=low
1233
1234 [ Daniel van Vugt ]
1235 [Daniel van Vugt]
1236 * Merge lp:compiz/raring back in to lp:compiz/0.9.9 so we can maintain
1237 raring from lp:compiz/0.9.9. The last common revision was 3629, so...
1238 * Automatic snapshot from revision 3629
1239
1240 [ MC Return <mc.return@gmx.net>, Sam Spilsbury <smspillaz@gmail.com>, Sam Spilsbury ]
1241 * Workspacenames plugin: Damage handling is broken and the plugin
1242 damages the full screen instead of just the painted part of it (LP:
1243 #1162246)
1244 * [regression-r3320] Workspacenames Plug-in: Flickering background on
1245 appearance, fade-out seems smooth (LP: #1075578)
1246
1247 [ Brandon Schaefer ]
1248 * [regression] Shortcut overlay does not hide when modifier key is
1249 pressed (LP: #1075207)
1250 * Unity blocks other programs from binding globally to Super+* (* =
1251 any key) (LP: #950160)
1252
1253 [ Sam Spilsbury <Sam@ACER-SUSE.SUSE>, Sam <Sam@XPS-SUSE.XPS>, Sam Spillaz <smspillaz@gmail.com>, Sam Spilsbury <smspillaz@gmail.com>, Sam Spilsbury <sam.spilsbury@canonical.com>, MC Return <mc.return@gmx.net>, Sam Spilsbury <Sam@XPS-SUSE.site>, users <warlock@banana.(none)>, Scott Moreau <oreaus@gmail.com>, Danny Baumann <dannybaumann@web.de>, warlock <warlock.cc@gmail.com>, Sam Spilsbury <smspillaz@XPS-U.(none)>, warlock <warlock@opencompositing.org>, Roland Bär ]
1254 * [needs-packaging] Wishlist: Missing plug-In: Freewins (Freely
1255 Transformable Windows) (LP: #1012194)
1256
1257 [ MC Return <mc.return@gmx.net>, Sam Spilsbury <sam.spilsbury@canonical.com>, Sam Spilsbury ]
1258 * Showdesktop plugin: Wishlist/Feature-Request: Implement "Random"
1259 movement direction option (LP: #1161343)
1260
1261 [ MC Return ]
1262 * Wall plugin: Redundant if (screen->otherGrabExist ("wall", 0)) check
1263 in WallScreen::initiateFlip (LP: #1160878)
1264 * CompWindow::syncPosition () function is empty and calls to it
1265 redundant (LP: #1160624)
1266 * Showdesktop plugin: Wishlist/Feature-Request: Implement "Random"
1267 movement direction option (LP: #1161343)
1268 * Multimonitor: Grid plugin: Wrong calculation of top left mouse-grid-
1269 resize corner coordinates (LP: #1139835)
1270
1271 [ Sam Spilsbury ]
1272 * After Upgrade to Boost 1.53 Build Fails (LP: #1131864)
1273 * Showdesktop plugin: Wishlist/Feature-Request: Implement "Random"
1274 movement direction option (LP: #1161343)
1275 * [regression] Unmaximized windows can't be closed, minimized, moved
1276 (LP: #1158161)
1277 * Latest compiz update breaks Java Swing decorations (LP: #1138517)
1278 * [regression-r3635] Guake window appears placed by offset non-
1279 existent decoration (LP: #1159324)
1280 * [regression-r3623] Wallpaper bleeds through on top right when a
1281 window is opened maximized (LP: #1140505)
1282 * xiphos crashed with SIGSEGV in sword::VerseKey::copyFrom() (LP:
1283 #1159234)
1284
1285 [ Ubuntu daily release ]
1286 * Automatic snapshot from revision 3644
1287
1288 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 05 Apr 2013 04:03:10 +0000
1289
1290compiz (1:0.9.9~daily13.03.29-0ubuntu1) raring; urgency=low
1291
1292 [ Michael Terry ]
1293 * [regression-r3635] Guake window appears placed by offset non-
1294 existent decoration (LP: #1159324)
1295
1296 [ Ubuntu daily release ]
1297 * Automatic snapshot from revision 3641
1298
1299 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Fri, 29 Mar 2013 07:23:54 +0000
1300
1301compiz (1:0.9.9~daily13.03.25-0ubuntu1) raring; urgency=low
1302
1303 [ Michael Terry ]
1304 * [regression] Unmaximized windows can't be closed, minimized, moved
1305 (LP: #1158161)
1306
1307 [ MC Return ]
1308 * Multimonitor: Grid plugin: Wrong calculation of top left mouse-grid-
1309 resize corner coordinates (LP: #1139835)
1310
1311 [ Ubuntu daily release ]
1312 * Automatic snapshot from revision 3639
1313
1314 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Mon, 25 Mar 2013 04:02:57 +0000
1315
1316compiz (1:0.9.9~daily13.03.20-0ubuntu1) raring; urgency=low
1317
1318 [ Sam Spilsbury ]
1319 * Latest compiz update breaks Java Swing decorations (LP: #1138517)
1320 * [regression-r3623] Wallpaper bleeds through on top right when a
1321 window is opened maximized (LP: #1140505)
1322
1323 [ Ubuntu daily release ]
1324 * Automatic snapshot from revision 3636
1325
1326 -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Wed, 20 Mar 2013 04:02:51 +0000
1327
1328compiz (1:0.9.9~daily13.03.08-0ubuntu1) raring; urgency=low
1329
1330 [ Brandon Schaefer ]
1331 * [regression] Shortcut overlay does not hide when modifier key is
1332 pressed (LP: #1075207)
1333 * Unity blocks other programs from binding globally to Super+* (* =
1334 any key) (LP: #950160)
1335
1336 [ Automatic PS uploader ]
1337 * Automatic snapshot from revision 3633
1338
1339 -- Automatic PS uploader <ps-jenkins@lists.canonical.com> Fri, 08 Mar 2013 10:34:21 +0000
1340
1341compiz (1:0.9.9~daily13.03.06-0ubuntu1) raring; urgency=low
1342
1343 [ Łukasz 'sil2100' Zemczak ]
1344 * Latest compiz update breaks Java Swing decorations (LP: #1138517)
1345
1346 [ Automatic PS uploader ]
1347 * Automatic snapshot from revision 3631
1348
1349 -- Automatic PS uploader <ps-jenkins@lists.canonical.com> Wed, 06 Mar 2013 13:26:19 +0000
1350
1351compiz (1:0.9.9~daily13.03.01-0ubuntu1) raring; urgency=low
1352
1353 [ MC Return ]
1354 * Multiple minor code and style issues (LP: #1134251)
1355
1356 [ Automatic PS uploader ]
1357 * Automatic snapshot from revision 3629
1358
1359 -- Automatic PS uploader <ps-jenkins@lists.canonical.com> Fri, 01 Mar 2013 04:02:19 +0000
61360
7compiz (1:0.9.9~daily13.02.28-0ubuntu1) raring; urgency=low1361compiz (1:0.9.9~daily13.02.28-0ubuntu1) raring; urgency=low
81362
91363
=== modified file 'debian/control'
--- debian/control 2013-08-19 16:32:52 +0000
+++ debian/control 2013-09-16 14:44:07 +0000
@@ -168,9 +168,17 @@
168 ${shlibs:Depends},168 ${shlibs:Depends},
169 ${misc:Depends},169 ${misc:Depends},
170Replaces: compiz-plugins-main-default (<< 1:0.9.8),170Replaces: compiz-plugins-main-default (<< 1:0.9.8),
171<<<<<<< TREE
171 compiz-plugins (<< 1:0.9.10),172 compiz-plugins (<< 1:0.9.10),
173=======
174 compiz-plugins (<< 1:0.9.10+13.10.20130828.1),
175>>>>>>> MERGE-SOURCE
172Breaks: compiz-plugins-main-default (<< 1:0.9.8),176Breaks: compiz-plugins-main-default (<< 1:0.9.8),
177<<<<<<< TREE
173 compiz-plugins (<< 1:0.9.10),178 compiz-plugins (<< 1:0.9.10),
179=======
180 compiz-plugins (<< 1:0.9.10+13.10.20130828.1),
181>>>>>>> MERGE-SOURCE
174Description: OpenGL window and compositing manager - default plugins182Description: OpenGL window and compositing manager - default plugins
175 Compiz brings to life a variety of visual effects that make the Linux desktop183 Compiz brings to life a variety of visual effects that make the Linux desktop
176 easier to use, more powerful and intuitive, and more accessible for users184 easier to use, more powerful and intuitive, and more accessible for users
177185
=== modified file 'debian/patches/series'
--- debian/patches/series 2013-02-28 18:48:38 +0000
+++ debian/patches/series 2013-09-16 14:44:07 +0000
@@ -5,5 +5,4 @@
5ccsm_add_first_run_warning.patch5ccsm_add_first_run_warning.patch
6ccsm_disable_unity_checkbox.patch6ccsm_disable_unity_checkbox.patch
799_valid_ccsm_desktop_file.patch799_valid_ccsm_desktop_file.patch
8unity_support_test.patch
9100_workaround_virtualbox_hang.patch8100_workaround_virtualbox_hang.patch
109
=== modified file 'debian/patches/ubuntu-config.patch'
--- debian/patches/ubuntu-config.patch 2013-09-06 22:46:03 +0000
+++ debian/patches/ubuntu-config.patch 2013-09-16 14:44:07 +0000
@@ -682,42 +682,6 @@
682 unsigned int DEFAULT_VIEWPORT_HEIGHT = 1;682 unsigned int DEFAULT_VIEWPORT_HEIGHT = 1;
683 683
684 bool Advance (Display *d, bool r)684 bool Advance (Display *d, bool r)
685--- a/plugins/grid/grid.xml.in
686+++ b/plugins/grid/grid.xml.in
687@@ -23,17 +23,16 @@
688 <option name="put_center_key" type="key">
689 <_short>Put Center Key</_short>
690 <_long>Move window to the center.</_long>
691- <default>&lt;Control&gt;&lt;Alt&gt;KP_5</default>
692 </option>
693 <option name="put_left_key" type="key">
694 <_short>Put Left Key</_short>
695 <_long>Move window to the left edge.</_long>
696- <default>&lt;Control&gt;&lt;Alt&gt;KP_4</default>
697+ <default>&lt;Control&gt;&lt;Super&gt;Left</default>
698 </option>
699 <option name="put_right_key" type="key">
700 <_short>Put Right Key</_short>
701 <_long>Move window to the right edge.</_long>
702- <default>&lt;Control&gt;&lt;Alt&gt;KP_6</default>
703+ <default>&lt;Control&gt;&lt;Super&gt;Right</default>
704 </option>
705 <option name="put_top_key" type="key">
706 <_short>Put Top Key</_short>
707@@ -68,12 +67,11 @@
708 <option name="put_maximize_key" type="key">
709 <_short>Maximize Key</_short>
710 <_long>Maximize window.</_long>
711- <default>&lt;Control&gt;&lt;Alt&gt;KP_0</default>
712 </option>
713 <option name="put_restore_key" type="key">
714 <_short>Restore</_short>
715 <_long>Restore window to it's original size. Note: Use the same shortcut you are using to unmaximize a window to be able to restore grid-maximized windows.</_long>
716- <default>&lt;Alt&gt;F5</default>
717+ <default>&lt;Control&gt;&lt;Super&gt;Down</default>
718 </option>
719 </group>
720 <group>
721--- a/plugins/ezoom/ezoom.xml.in685--- a/plugins/ezoom/ezoom.xml.in
722+++ b/plugins/ezoom/ezoom.xml.in686+++ b/plugins/ezoom/ezoom.xml.in
723@@ -30,7 +30,7 @@687@@ -30,7 +30,7 @@
@@ -852,6 +816,7 @@
852 </option>816 </option>
853 <option name="ground_color1" type="color">817 <option name="ground_color1" type="color">
854 <_short>Ground Color (near)</_short>818 <_short>Ground Color (near)</_short>
819<<<<<<< TREE
855--- a/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml820--- a/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
856+++ b/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml821+++ b/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
857@@ -10,6 +10,9 @@822@@ -10,6 +10,9 @@
@@ -893,3 +858,46 @@
893 </option>858 </option>
894 </group>859 </group>
895 <group>860 <group>
861=======
862--- a/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
863+++ b/compizconfig/integration/gnome/gsettings/org.compiz.integrated.gschema.xml
864@@ -10,6 +10,9 @@
865 <key type="s" name="command-screenshot">
866 <default>"gnome-screenshot"</default>
867 </key>
868+ <key type="as" name="run-command-21">
869+ <default>["&lt;Control&gt;&lt;Alt&gt;Delete"]</default>
870+ </key>
871 <key type="as" name="run-command-12">
872 <default>["Disabled"]</default>
873 </key>
874@@ -46,6 +49,9 @@
875 <key type="as" name="run-command-1">
876 <default>["Disabled"]</default>
877 </key>
878+ <key type="s" name="command-21">
879+ <default>"/usr/bin/gnome-system-monitor -p"</default>
880+ </key>
881 <key type="s" name="command-12">
882 <default>""</default>
883 </key>
884--- a/plugins/commands/commands.xml.in
885+++ b/plugins/commands/commands.xml.in
886@@ -117,7 +117,7 @@
887 <option name="command20" type="string">
888 <_short>Command line 20</_short>
889 <_long>Command line to be executed in shell when run_command20 is invoked</_long>
890- <default></default>
891+ <default>/usr/bin/gnome-system-monitor -p</default>
892 </option>
893 </group>
894 <group>
895@@ -205,6 +205,7 @@
896 <option name="run_command20_key" type="key">
897 <_short>Run command 20</_short>
898 <_long>A keybinding that when invoked, will run the shell command identified by command20</_long>
899+ <default>&lt;Control&gt;&lt;Alt&gt;Delete</default>
900 </option>
901 </group>
902 <group>
903>>>>>>> MERGE-SOURCE
896904
=== removed file 'debian/patches/unity_support_test.patch'
--- debian/patches/unity_support_test.patch 2012-10-09 13:05:32 +0000
+++ debian/patches/unity_support_test.patch 1970-01-01 00:00:00 +0000
@@ -1,90 +0,0 @@
1# Description: force llvmpipe in the unity profile if we are in the grey zone,
2# meaning: the card and drivers have opengl support, however,
3# it doesn't met unity requirements (opengl < 1.4, no vertex
4# shaders support…).
5# Forwarded: not-needed
6# Bug: https://launchpad.net/bugs/1039155
7# Author: Daniel van Vugt <daniel.van.vugt@canonical.com>
8=== modified file 'src/plugin.cpp'
9--- old/src/plugin.cpp 2012-07-30 10:15:41 +0000
10+++ new/src/plugin.cpp 2012-10-09 10:52:12 +0000
11@@ -116,6 +116,60 @@
12 }
13
14 static bool
15+setOpenGLPluginEnvironment ()
16+{
17+ /*
18+ * Check if the hardware is adequate for Unity and if not, use LLVMpipe.
19+ * Unfortunately the design of Mesa requires that this be done before
20+ * libGL is loaded, which means before the opengl plugin is loaded.
21+ */
22+ bool toggledLLVM = false;
23+
24+ if (!getenv ("LIBGL_ALWAYS_SOFTWARE"))
25+ {
26+ const char *profile = getenv ("COMPIZ_CONFIG_PROFILE");
27+ if (profile && !strcmp (profile, "ubuntu"))
28+ {
29+ int result = system ("/usr/lib/nux/unity_support_test");
30+ int status = WEXITSTATUS (result);
31+ compLogMessage ("core", CompLogLevelInfo,
32+ "Unity is %s",
33+ status == 0 ? "fully supported by your hardware." :
34+ status == 127 ? "undetectable" :
35+ "not supported by your hardware. "
36+ "Enabling software rendering instead (slow).");
37+ if (status > 0 && status < 127)
38+ {
39+ setenv ("LIBGL_ALWAYS_SOFTWARE", "1", 1);
40+ toggledLLVM = true;
41+ }
42+ }
43+ }
44+
45+ return toggledLLVM;
46+}
47+
48+static void
49+unsetUnityshellPluginEnvironment ()
50+{
51+ unsetenv ("LIBGL_ALWAYS_SOFTWARE");
52+}
53+
54+static void
55+setPluginEnvironment (const char *name)
56+{
57+ if (!strcmp (name, "opengl"))
58+ setOpenGLPluginEnvironment ();
59+}
60+
61+static void
62+unsetPluginEnvironment (const char *name)
63+{
64+ if (!strcmp (name, "unityshell"))
65+ unsetUnityshellPluginEnvironment ();
66+}
67+
68+static bool
69 dlloaderLoadPlugin (CompPlugin *p,
70 const char *path,
71 const char *name)
72@@ -127,6 +181,8 @@
73 if (cloaderLoadPlugin (p, path, name))
74 return true;
75
76+ setPluginEnvironment (name);
77+
78 if (path)
79 {
80 file = path;
81@@ -197,6 +253,8 @@
82 if (!loaded && dlhand)
83 dlclose (dlhand);
84
85+ unsetPluginEnvironment (name);
86+
87 return loaded;
88 }
89
90

Subscribers

People subscribed via source and target branches