Code review comment for lp:~3v1n0/bamf/wmclass-matching
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I am not sure I'm the right person to review this branch, but I got one nitpick nontheless :-)
The get_class() and set_class() methods on BamfApplication are not very binding friendly. If I called app.get_class() from Vala or PyGI it would normally give me the GObjectClass struct for the object, but this patch would override that method.
Maybe get/set_wmclass() instead?