Code review comment for lp:~3v1n0/bamf/upstart-support

Revision history for this message
Martin Pitt (pitti) wrote :

This adds quite a lot of complexity and potential for brittleness. You already had a followup fix for bamfdaemon-dbus-runner.in, having this redirector is quite ugly, and it assumes that the start condition

  start on (starting hud or starting unity-panel-service or starting unity7)

is correct and complete for all times. I. e. if someone tries to use bamf under Ubuntu GNOME, you will get 25s D-Bus timeouts.

D-Bus activation starts up the service *exactly* when and if it's needed, provides automatic restarts, and avoids all of this.

What was the rationale for this? It would be nice if commit logs would explain the "why", not (just) the "what". Thanks!

« Back to merge proposal