Merge lp:~3v1n0/bamf/missing_files_v2 into lp:bamf/0.4

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 481
Merged at revision: 479
Proposed branch: lp:~3v1n0/bamf/missing_files_v2
Merge into: lp:bamf/0.4
Diff against target: 65 lines (+11/-6)
3 files modified
Makefile.am (+1/-1)
src/Makefile.am (+8/-5)
tests/bamfdaemon/Makefile.am (+2/-0)
To merge this branch: bzr merge lp:~3v1n0/bamf/missing_files_v2
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+117661@code.launchpad.net

Commit message

tests: include the tests data dir in distribution

Description of the change

We still miss the test data in distribution, or make distcheck won't work ;)

To post a comment you must log in.
lp:~3v1n0/bamf/missing_files_v2 updated
480. By Marco Trevisan (Treviño)

Bamfdaemon, put BUILT_SOURCES back

481. By Marco Trevisan (Treviño)

BamfDaemon, correctly build the gdbus files

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

After those 2 fixes everything builds correctly - thanks! Approve.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile.am'
--- Makefile.am 2012-02-17 11:12:57 +0000
+++ Makefile.am 2012-08-01 14:31:21 +0000
@@ -10,5 +10,5 @@
10 doc10 doc
1111
12EXTRA_DIST = COPYING.LGPL autogen.sh build.rules.mk12EXTRA_DIST = COPYING.LGPL autogen.sh build.rules.mk
13DISTCHECK_CONFIGURE_FLAGS = --enable-introspection=no --enable-gtk-doc13DISTCHECK_CONFIGURE_FLAGS = --enable-introspection=no --enable-gtk-doc=yes
1414
1515
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2012-08-01 11:37:03 +0000
+++ src/Makefile.am 2012-08-01 14:31:21 +0000
@@ -1,7 +1,8 @@
1# Defined as these will be needed by Makefile.am.marshal
1CLEANFILES =2CLEANFILES =
2DISTCLEANFILES =3DISTCLEANFILES =
3BUILT_SOURCES =4BUILT_SOURCES =
4EXTRA_DIST = 5EXTRA_DIST =
56
6include $(top_srcdir)/Makefile.am.marshal7include $(top_srcdir)/Makefile.am.marshal
78
@@ -80,14 +81,13 @@
80 $(NULL)81 $(NULL)
8182
82bamfdaemon_SOURCES = \83bamfdaemon_SOURCES = \
83 $(bamfdaemon_built_sources) \
84 $(bamfdaemon_sources) \84 $(bamfdaemon_sources) \
85 $(bamfdaemon_headers) \85 $(bamfdaemon_headers) \
86 $(NULL)86 $(NULL)
8787
88nodist_EXTRA_bamfdaemon_SOURCES = \88nodist_bamfdaemon_SOURCES = \
89 $(bamfdaemon_gdbus_files) \89 $(bamfdaemon_built_sources) \
90 $(NULL)90 $(NULL)
9191
92glib_marshal_list = bamf-marshal.list92glib_marshal_list = bamf-marshal.list
93glib_marshal_prefix = bamf_marshal93glib_marshal_prefix = bamf_marshal
@@ -144,6 +144,9 @@
144 --interface-prefix com.canonical.StatusNotifierApprover \144 --interface-prefix com.canonical.StatusNotifierApprover \
145 $<145 $<
146146
147dist-hook:
148 find $(top_distdir)/src -name bamf-gdbus-\*-generated.\* -exec rm -v {} \;
149
147BUILT_SOURCES += \150BUILT_SOURCES += \
148 $(bamfdaemon_gdbus_files) \151 $(bamfdaemon_gdbus_files) \
149 $(NULL)152 $(NULL)
150153
=== modified file 'tests/bamfdaemon/Makefile.am'
--- tests/bamfdaemon/Makefile.am 2012-07-17 19:03:36 +0000
+++ tests/bamfdaemon/Makefile.am 2012-08-01 14:31:21 +0000
@@ -82,6 +82,8 @@
82 -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions \82 -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions \
83 $(NULL)83 $(NULL)
8484
85EXTRA_DIST = data
86
85# Run tests as part of make check87# Run tests as part of make check
86if ENABLE_HEADLESS_TESTS88if ENABLE_HEADLESS_TESTS
87check-local: test-headless89check-local: test-headless

Subscribers

People subscribed via source and target branches