Code review comment for lp:~274914765-t/terminator/terminator

Revision history for this message
Stephen Boddy (stephen-j-boddy) wrote :

From a quick look, this is incomplete. There is no GUI way for the user to set this value. If I've understood correctly I'd have to edit the config by hand. Which is fine until I save another setting, and the "position=center" entry gets overwritten... so I change it by hand again... and so on.

Also you are using a text editor that automatically trims whitespace. Unless submitting a change specifically to fix whitespace, please try to avoid including those, as they just add noise (not a problem here, but best to be consistent :-)

review: Needs Fixing

« Back to merge proposal