Merge lp:~1chb1n/charm-helpers/os-amulet-keystone-ip into lp:charm-helpers

Proposed by Ryan Beisner
Status: Merged
Merged at revision: 641
Proposed branch: lp:~1chb1n/charm-helpers/os-amulet-keystone-ip
Merge into: lp:charm-helpers
Diff against target: 27 lines (+4/-6)
1 file modified
charmhelpers/contrib/openstack/amulet/utils.py (+4/-6)
To merge this branch: bzr merge lp:~1chb1n/charm-helpers/os-amulet-keystone-ip
Reviewer Review Type Date Requested Status
James Page Approve
Review via email: mp+307510@code.launchpad.net

Description of the change

Update OpenStack Amulet helper to get keystone address from sentry info instead of relation data

To post a comment you must log in.
Revision history for this message
James Page (james-page) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'charmhelpers/contrib/openstack/amulet/utils.py'
--- charmhelpers/contrib/openstack/amulet/utils.py 2016-09-11 03:28:39 +0000
+++ charmhelpers/contrib/openstack/amulet/utils.py 2016-10-04 04:46:39 +0000
@@ -306,10 +306,8 @@
306 password, tenant):306 password, tenant):
307 """Authenticates admin user with cinder."""307 """Authenticates admin user with cinder."""
308 # NOTE(beisner): cinder python client doesn't accept tokens.308 # NOTE(beisner): cinder python client doesn't accept tokens.
309 service_ip = \309 keystone_ip = keystone_sentry.info['private-address']
310 keystone_sentry.relation('shared-db',310 ept = "http://{}:5000/v2.0".format(keystone_ip.strip().decode('utf-8'))
311 'mysql:shared-db')['private-address']
312 ept = "http://{}:5000/v2.0".format(service_ip.strip().decode('utf-8'))
313 return cinder_client.Client(username, password, tenant, ept)311 return cinder_client.Client(username, password, tenant, ept)
314312
315 def authenticate_keystone_admin(self, keystone_sentry, user, password,313 def authenticate_keystone_admin(self, keystone_sentry, user, password,
@@ -319,8 +317,8 @@
319 self.log.debug('Authenticating keystone admin...')317 self.log.debug('Authenticating keystone admin...')
320 unit = keystone_sentry318 unit = keystone_sentry
321 if not keystone_ip:319 if not keystone_ip:
322 keystone_ip = unit.relation('shared-db',320 keystone_ip = keystone_sentry.info['private-address']
323 'mysql:shared-db')['private-address']321
324 base_ep = "http://{}:35357".format(keystone_ip.strip().decode('utf-8'))322 base_ep = "http://{}:35357".format(keystone_ip.strip().decode('utf-8'))
325 if not api_version or api_version == 2:323 if not api_version or api_version == 2:
326 ep = base_ep + "/v2.0"324 ep = base_ep + "/v2.0"

Subscribers

People subscribed via source and target branches