Code review comment for lp:~1chb1n/charm-helpers/heat-amulet

Revision history for this message
Corey Bryant (corey.bryant) wrote :

> I'd prefer to not do that actually. I'd like to take it smaller chunks.
>
> This is what I'm aiming for:
>
> 1. Land heat amulet tests, at the same time unblocking vivid for all of the
> other amulet tests.
>
> 2. Enable and land vivid coverage in all of the charms with existing amulet
> tests, while also updating each of them.
>
> 3. Deprecate the old validate_services after it is confirmed to be not-used.
>
> 4. Add amulet tests for charms which don't yet have them.
>
> Whaddaya think?

I just prefer not to land code that's going to be pulled back out in a week. But I can't land to c-h anyway so it's not up to me.

Now that I think of it though, and more importantly, I don't know what the process is for deprecating functions that aren't openstack specific. Someone else might already be using them and some of these changes would break them. I wonder what the precedence is.

« Back to merge proposal