OpenStack Compute (nova)

Code review comment for lp:~0x44/nova/config-drive

  1. config-drive
  2. Merge into trunk
Revision history for this message
Dan Prince (dan-prince) wrote :

Hi Chris,

Is there a reason that this feature is exposed via the OSAPI? Why not just enable or disable it via a flag via the config file? If we do need to expose it via the API then perhaps an extension would be better?

If guests are using this to pull in configuration metadata then it seems like you would just always want it on.

---

Also, You have a conflict in nova/api/openstack/create_instance_helper.py.

review: Needs Information

« Back to merge proposal