Comment 10 for bug 1835968

Revision history for this message
Bryce Harrington (bryce) wrote :

Doing a quick scan through the patches, these look interesting:
* 0013-test-test_x509name-change-script-encoding-to-ASCII-8.patch
* 0014-x509name-refactor-OpenSSL-X509-Name-to_s.patch
* 0015-x509name-fix-handling-of-X509_NAME_-oneline-print_ex.patch
* 0016-openssl-buffering.rb-no-RS-when-output.patch (***)
* 0017-Reduce-memory-allocation-when-writing-to-SSLSocket.patch

Patch 0016 is the one that changes the line ending behavior in buffering.rb and so would probably be the one to test first. 0015 and 0016 also change buffering.rb, while 0013 and 0014 involve utf/ascii conversions so could be involved in some fashion.

I don't know precisely what was required for supporting openssl 1.1, however the earlier patches in the series (particularly 0005, 0006 and 0007, and likely 0001, 0002, and 0004) look most pertinent for that, so I suspect if we were to revert one or more of 0013 to 0017, it may not adversely affect desired functionality although they do appear to fix legit issues and probably worth keeping.

(Fwiw, patches 0009, 0010, and 0012 appear to be MS Windows specific so might be irrelevant to Ubuntu. Patches 0008 and 0011 appear to just be refactoring, although not 100% sure. 0003 is just docs.)