Comment 12 for bug 1026442

Revision history for this message
Iain Lane (laney) wrote :

Thanks for your change.

Hoever, the patch is wrong - it fails to compile

/«PKGBUILDDIR»/./pidgin/gtkpounce.c: In function 'pidgin_pounce_editor_show':
/«PKGBUILDDIR»/./pidgin/gtkpounce.c:690:31: error: 'send_msg_webview' undeclared (first use in this function)
/«PKGBUILDDIR»/./pidgin/gtkpounce.c:690:31: note: each undeclared identifier is reported only once for each function it appears in

The correct variable is (seemingly) send_msg_imhtml. Can you please update the patch you filed upstream?

Now I'm concerned about the level of testing that this can have received. Please can you re-verify with these patches and outline the testing you've done? I'll attach the debdiffs that I just worked out when looking to sponsor this so that someone else can pick this up next time.