keystoneclient endpoint-create should require service_id

Bug #987457 reported by Dolph Mathews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Dolph Mathews

Bug Description

It doesn't make sense to try to attempt to create an endpoint without referencing a service. Currently, this results in a server-side failure (a default value of None is assumed when it's not required).

    $ keystone endpoint-create
    Could not find service: None (HTTP 404)

It would make a bit *more* sense if service_id was the only *required* option, as region can be logically defaulted:

    $ keystone endpoint-create
    usage: keystone endpoint-create [--region <endpoint-region>] --service_id
                                    <service-id> [--publicurl <public-url>]
                                    [--adminurl <admin-url>]
                                    [--internalurl <internal-url>]
    keystone endpoint-create: error: argument --service_id is required

This successfully produces an endpoint (albeit without any URL's, but I think that's another issue being discussed on the mailing list (https://lists.launchpad.net/openstack/msg10322.html):

    $ keystone endpoint-create --service_id=34d34a251eea431cb2ca89c6dd360109
    +-------------+----------------------------------+
    | Property | Value |
    +-------------+----------------------------------+
    | adminurl | None |
    | id | fb6c1aab4ed04c94969fe6aef4670359 |
    | internalurl | None |
    | publicurl | None |
    | region | regionOne |
    | service_id | 34d34a251eea431cb2ca89c6dd360109 |
    +-------------+----------------------------------+

Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
assignee: nobody → Dolph Mathews (dolph)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6729

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/6729
Committed: http://github.com/openstack/python-keystoneclient/commit/ee220c19a883a6ce5bb25d010f94822ed5e88222
Submitter: Jenkins
Branch: master

commit ee220c19a883a6ce5bb25d010f94822ed5e88222
Author: Dolph Mathews <email address hidden>
Date: Mon Apr 23 13:45:14 2012 -0500

    Require service_id for endpoint-create (bug 987457)

    Change-Id: I6568fcee740fb497afe8f3fd824c7c93dfc8304d

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.