Ubuntu
glib-networking package

glib-pacrunner does not support file:// pac files

Bug #981856 reported by Chow Loong Jin on 2012-04-14

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Glib Networking	Fix Released	Medium	gnome-bugs #674115
glib-networking (Ubuntu)	Fix Released	Undecided	Unassigned	Ubuntu precise-updates
Precise	Fix Released	Undecided	Unassigned	Ubuntu precise-updates

Bug Description

When using a local pac file via file:///path/to/pac-file.pac, glib-pacrunner falls back upon wpad://, thus using either a wrongly-obtained pac file via wpad, or not being able to find a pac file to run in the first place.

This causes issues with Liferea's Webkit-based HTML-view, and probably a couple of other applications I haven't noticed as well.

TEST CASE:
1. Open Liferea
2. Subscribe to the xkcd.com feed
3. Click on one of the feed items
4. Notice that an image is displayed.
5. Save the following as a .pac file, e.g. in /tmp/bug-981856.pac
---->8----
function FindProxyForURL(url, host) {
return 'DIRECT';
}
----8<-----
6. Quit Liferea
7. Set proxy in GNOME to file:///tmp/bug-981856.pac
9. Open Liferea
10. Click on a previously unopened feed item (the image may be cached)
11. Observe if the image loads
- With the bugfix in place, it should, but without, it doesn't.

See original description

Tags:

Related branches

lp:ubuntu/quantal/glib-networking

Revision history for this message

Chow Loong Jin (hyperair) wrote on 2012-04-14:

I'll attach a patch for this shortly.

Revision history for this message

Chow Loong Jin (hyperair) wrote on 2012-04-14:

Debdiff to fix this

Changed in glib-networking (Ubuntu):
status:	New → Confirmed

Bug Watch Updater (bug-watch-updater) on 2012-04-14

Changed in glib-networking:
importance:	Unknown → Medium
status:	Unknown → New

Revision history for this message

Bryce Harrington (bryce) wrote on 2012-04-19:

Heya, thanks for the patch!

Unfortunately development on Precise has closed, as we're now in Final Freeze. This looks like an important bug, but only fixes for issues specifically flagged by the release team can be included in Precise here on out.

However, there's a chance this could get in as a Stable Release Update, which would go out post-release. I'm not certain if this qualifies, but below is a link to the policy document for you to review. It also explains how to update your bug report into an SRU, if you decide this issue really does need fixed in precise. Otherwise, hold tight and this can go in once Q-series opens for development.

https://wiki.ubuntu.com/StableReleaseUpdates

Btw, please also make sure this patch is sent upstream; it likely won't be acceptable as an SRU until then.

I'm unsubscribing ubuntu-sponsors for now; go ahead and re-subscribe them when it's ready to be reviewed again.

Changed in glib-networking (Ubuntu):
status:	Confirmed → Incomplete

Bug Watch Updater (bug-watch-updater) on 2012-04-23

Changed in glib-networking:
status:	New → Fix Released

Revision history for this message

Chow Loong Jin (hyperair) wrote on 2012-04-24:

Updated debdiff Edit (2.2 KiB, text/plain)

Here's an amended debdiff incorporating the patch extracted from upstream git, and targetting precise-proposed instead.

Changed in glib-networking (Ubuntu):
status:	Incomplete → Confirmed
milestone:	none → precise-updates

Chow Loong Jin (hyperair) on 2012-04-24

description:

updated

Revision history for this message

Daniel Holbach (dholbach) wrote on 2012-04-24:

Patch uploaded, I merely had to run 'update-maintainer'. Ran through the test-case - after updating glib-networking (and restarting the session) it works nicely.

It should be sitting in the SRU/Release queue now.

Changed in glib-networking (Ubuntu Precise):
status:	Confirmed → Fix Committed

Revision history for this message

Daniel Holbach (dholbach) wrote on 2012-04-24:

Unsubscribing sponsors for now.

Revision history for this message

Martin Pitt (pitti) wrote on 2012-04-24: Please test proposed package

Hello Chow, or anyone else affected,

Accepted glib-networking into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags:

added: verification-needed

Revision history for this message

Martin Pitt (pitti) wrote on 2012-05-02:

Anyone who can test this?

Revision history for this message

Daniel Holbach (dholbach) wrote on 2012-05-02:

I tested the instructions in the initial comment and it worked for me.

Jean-Baptiste Lallement (jibel) on 2012-05-02

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-05-02:

#10

This bug was fixed in the package glib-networking - 2.32.1-1ubuntu1

---------------
glib-networking (2.32.1-1ubuntu1) precise-proposed; urgency=low

* debian/patches/fix-file-scheme-pacfiles.patch:
- Allow usage of file:// pac files (LP: #981856)
-- Chow Loong Jin <email address hidden> Tue, 24 Apr 2012 09:20:08 +0800

Changed in glib-networking (Ubuntu):
status:	Fix Committed → Fix Released
Changed in glib-networking (Ubuntu Precise):
status:	Fix Committed → Fix Released